Laike-Endaril / Dynamic-Stealth

Introducing actual stealth mechanics to Minecraft
https://minecraft.curseforge.com/projects/dynamic-stealth
18 stars 2 forks source link

Bibliocraft Compatibility (or the lack thereof) #99

Closed DD12-1916 closed 4 years ago

DD12-1916 commented 4 years ago

Low priority, I guess? Anyway, Bibliocraft Armour Stands render incorrectly, as either Steve or Alex's player models appear when the armour stands are placed down. In contrast, vanilla armour stands appear to be normal.

I have confirmed that Dynamic Stealth is indeed the cause, mainly because I saw a person in a Discord server mention that this was the case. I have also tried to put in the Bibliocraft Armour Stands in the Entity-Specific Full Bypass to see if that would work, but sadly, it didn't. I put in 'bibliocraft:armorstand', which was the ID of the item. Turns out, no such entity exists for any of the armour stands, as far as I know.

Screenshot (22)

By the way, such an awesome mod you got here :)

Tommsy64 commented 4 years ago

It looks like the Bibliocraft armor stand renderer uses the following AbstractClientPlayer class

public class AbtractSteve extends AbstractClientPlayer {
    private static GameProfile gp = new GameProfile(UUID.randomUUID(), "BiblioSteve");

    public AbtractSteve(World world) {
        super(world, gp);
        this.setInvisible(true);
    }
}

while Dynamic Stealth sets every entity to be visible before rendering.

    @SubscribeEvent(priority = EventPriority.LOWEST, receiveCanceled = true)
    public static void preRender(RenderLivingEvent.Pre event) {
    ......
        //Don't draw seen entities as invisible, because they've been SEEN
        livingBase.setInvisible(false);
Laike-Endaril commented 4 years ago

Sorry I've been inactive on here for a while; looking through this one now (and I do see your related PR)

Laike-Endaril commented 4 years ago

This should now be fixed in the latest release (104)

DD12-1916 commented 4 years ago

I tested 1.0.4 just now and it does indeed work, thank you so much!

Laike-Endaril commented 4 years ago

Thanks again @Tommsy64 for this one, you're in the mod credits