search

Lailloken / Lailloken-UI

Path of Exile UI and QoL overlay. Emphasizes ease of use, minimalist design, and seamless integration.
MIT License
594 stars 28 forks source link

Omnikey triggering Stash-Ninja on rare amulets with scarab in name #385

Closed MadMarbleHead closed 6 months ago

MadMarbleHead commented 6 months ago

The title mostly sums it up. When the omnikey is long-pressed over an amulet with scarab in the name, stash-ninja is triggered instead of Item-Info.

This occurs in 1.53.2 on uninfluenced, single influenced, and double influenced rare amulets in stash tab, quad stash tabs, premium stash tab center slots, in inventory, and while equipped. image image image image image

Item info is invoked (and does not function) correctly on Skittering Incubators and divination cards with scarab in the item description, both in stash and inventory. image image

Amulets appear to be the only rare items with scarab in the name, so it appears to a non-issue on other item types.

Lailloken commented 6 months ago

Thanks for your thorough reporting, very much appreciated. Since the live-version only supports the scarab tab, I went with the lazy/placeholder route when I coded the activation of the feature. I did check the trade-site beforehand to see whether names with "scarab" can be generated, but I couldn't find anything. I should've checked my own stash because I do have an amulet with "scarab" in its name.

My local dev-version already supports the "general" and "breach" sub-tabs within the fragment tab, so the omni-key activation has been changed accordingly. I can create a hotfix release that includes that.

MadMarbleHead commented 6 months ago

Glad to hear it! I'm absolutely in love with this tool and am excited to see it continue to grow.

Lailloken commented 6 months ago

Should be fixed in v1.53.2 (Hotfix 1).

MadMarbleHead commented 6 months ago

I downloaded and tested it, it's working on my end.