search

LakeEffectRobotics / LER_2019

2019 Destination Deep Space
Apache License 2.0
0 stars 0 forks source link

Emka725 #1

Closed emka725 closed 5 years ago

emka725 commented 5 years ago

Sooner or later I'll have to figure out what needs to happen to the old autonomous code.

gbuckholtz commented 5 years ago

@emka725 , Jeremy will be in around lunch time and he can help with the merge of this pull request

jeremyroy commented 5 years ago

Good work! I added a few comments to the code that I think should be addressed before we merge this with develop. Otherwise, the changes made look great!

gbuckholtz commented 5 years ago

@emka725 , can you have a look at @jeremyroy 's comments in the emka725 branch? Then we can merge these changes into master.

emka725 commented 5 years ago

@gbuckholtz I've seen the comments now; looks good to me.

Edit: I accidentally closed this pull request and reopened it immediately after.

gregk27 commented 5 years ago

Some of these changes may need to wait until #11 as the wpilib.Spark library is for the older Spark controllers, whereas revrobotics.CANSparkMax is for the new Spark Maxes we use

gbuckholtz commented 5 years ago

Hi @emka725 ! There was another branch that Greg and Ajay were working on that has the conversion to CANSparks plus a whole lot more to get the code running on the robot. Can you update this branch with develop? Then we can put the other changes you made in this branch into develop.

Thanks!

emka725 commented 5 years ago

@gbuckholtz Alright, will do.

gbuckholtz commented 5 years ago

It doesn't have to be called ShawnDrive. I just suggested it since it was just the logical extension of TimDrive and the *Drive before it. Feel free to name it something else. All that is important is that it works! ;) (Or eventually works... rarely does anything work the first time! lol)

ajayyy commented 5 years ago

You don't have to call it ShawnDrive if you don't want to

gregk27 commented 5 years ago

It's a tradition. First there was DylanDrive, then there was EwanDrive, then TimDrive. AjayDrive existed as a joke.

ajayyy commented 5 years ago

aJaydrIve lives on in the 2016 code

timelapse21 commented 5 years ago

aJaydrlve deserves to die

gbuckholtz commented 5 years ago

I think this pull request is causing a problem with my updating the emka725 branch. I am going to close this pull request and then update ema725 branch THEN issue a pull request on develop