search

LakeEffectRobotics / LER_2019

2019 Destination Deep Space
Apache License 2.0
0 stars 0 forks source link

Greg #11

Closed gregk27 closed 5 years ago

gregk27 commented 5 years ago

Removed unneeded code from last year (Mostly auto stuff) and renamed/simplified remaining code to be used as base.

We normally rewrite base code each year, so this will help get things started

gregk27 commented 5 years ago

Added commit that changes drivetrain to use new motors

gregk27 commented 5 years ago

Just read other pull, not sure on difference between Spark and CANSparkMax. (I think that Spark uses PWM)

gbuckholtz commented 5 years ago

Just read other pull, not sure on difference between Spark and CANSparkMax. (I think that Spark uses PWM)

I believe you are right on that. We certainly want to use the CANSparkMax's

FYI @jeremyroy isn't going to be around today.

Do we have a robot you can deploy your code to? I assume the code at least compiles.

gregk27 commented 5 years ago

I must have missed it when deleting, ill re-add it later

gregk27 commented 5 years ago

And we are assembling chassis today

gbuckholtz commented 5 years ago

@Aree-Vanier , does the code compile?

gregk27 commented 5 years ago

Not at the moment, as when I renamed a file, commit -a didn't add it

gregk27 commented 5 years ago

@gbuckholtz I think the code used to drive straight in teleop is in StraightGyroDriveCommand, which is not deleted

gbuckholtz commented 5 years ago

@Aree-Vanier , I am going to do the merge this afternoon.

gregk27 commented 5 years ago

@gbuckholtz Tested on new chassis, works like a charm

gbuckholtz commented 5 years ago

@Aree-Vanier @ajayyy , the automated build seems to have failed. Is this the exact code that is on the working bot now? Or is it a problem with the automated build?

gregk27 commented 5 years ago

@gbuckholtz There was an import that got missed when commiting, ill remove in a sec