LakeMaps / boat

Lake Maps' boat control software
Open Software License 3.0
3 stars 0 forks source link

Fix recv port for propulsion microcontroller #124

Closed whymarrh closed 6 years ago

whymarrh commented 6 years ago

This PR fixes the recv port passed to the propulsion microcontroller. It was incorrectly reading from the GPS serial port.

This PR represents the first bug discovered using the dev kit 🎉 🤖

arandell93 commented 6 years ago

Dev Kit Hype!

What is the potential downside of fixing the port for the propulsion microcontroller? Will this affect the unplug game? How can we be sure it will be assigned correctly if, for example, we replace the hardware or image?

whymarrh commented 6 years ago

What is the potential downside of fixing the port for the propulsion microcontroller? Will this affect the unplug game? How can we be sure it will be assigned correctly if, for example, we replace the hardware or image?

This is fix in the other use of the word (i.e. repair)

arandell93 commented 6 years ago

😌