Closed Deldaflyer closed 2 years ago
Hello.
Thanks for the PR. These are some great additions for self-hosted instances.
This may take extra time to review due to the number of changes grouped into a single revision. I may end up splitting this into a couple PRs using git cherry-pick
or a similar function. If so, I'll tag you in the relevant request(s) for further discussion.
This will need a bit more tweaking before I can merge due to a number of formatting issues within the code. I would advise installing ESLint in your editor to see this yourself (There's a pre-configured ESLint ruleset in the repo, so it should sync up when you run it). We'll work on this in the coming days.
I've re-staged these changes in the above PRs, see above for further reference.
Apologies again for the increased delay. I plan to review the remaining changes soon.
Good news! The remainder of these features are now integrated into the 2.0 branch for the upcoming major update. I will be closing this out shortly, along with #193 and #195. See here:
https://github.com/LakeYS/Discord-Trivia-Bot/blob/2.0/lib/game_extensions.js#L8 https://github.com/LakeYS/Discord-Trivia-Bot/blob/2.0/lib/platform/discord_main.js#L227
Hello Lake,
kind regards, Deltaflyer