search

LakeYS / Discord-Trivia-Bot

TriviaBot: Play trivia in Discord! Powered by discord.js and OpenTDB, with 24 categories and three modes of play.
http://lakeys.net/triviabot/
Apache License 2.0
84 stars 39 forks source link

Cleaned up cmd_help.js #213

Closed Peterr-K closed 3 years ago

Peterr-K commented 3 years ago

Cleaned up cmd_help.js and removed posting of the version of discord.js. Posting version of any library may be usefull for hackers to find what vulnerability is present. If you disagree, just add the string printing discord.js version.

LakeYS commented 3 years ago

The cleanup is much appreciated!

As for the discord.js version, we likely will want to add it back to the string. The package version is available in the package.json for public access regardless. Additionally, a number of Discord bot listings request the library version be posted for reference, so it wouldn't be a good idea to leave the version number out.

Any security issues are unlikely based on existing audits, and further concerns will be addressed with an upgrade to the library in the near future.

I will look this over more this week and make the necessary adjustments before merging.

Peterr-K commented 3 years ago

no problem, discord.js version added.