search

Lakelezz / audiopus_sys

Rust FFI-binding of Opus.
ISC License
14 stars 21 forks source link

Set bindgen version to 0 to avoid linking error #3

Closed MOZGIII closed 4 years ago

MOZGIII commented 4 years ago

This is a hack, but it's the best we can do for now Closes #2

MOZGIII commented 4 years ago

This isn't going work (for me at least) because of semantic versioning logic: before version 1 no versions are considered compatible, so in that sense it should make no difference. To elaborate: version 0.51 would not be compatible with 0.52, and we'd end up with the same outcome. The only real solution currently (even though it's unsound) is to have it depend on 0 or *.

Lakelezz commented 4 years ago

Rust uses a modified SemVer, take a look for compatibility before 1.0.0 here: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements

MOZGIII commented 4 years ago

What's your point?

MOZGIII commented 4 years ago

The core issue the bindgen is conflicting with other dependencies that are also using bindgen. If some dependency requires bindgen 0.51, and some other requires 0.52, there's no version that can be used, even though it's usually ok with bindgen in particular.

Lakelezz commented 4 years ago

Thanks for the pull request. However, this could be resolved in a different way, see #2.