search

Lakhankumawat / LearnCPP

Learn Cpp from Beginner to Advanced ✅ Practice 🎯 Code 💻 Repeat 🔁 One step solution for c++ beginners and cp enthusiasts.
https://lakhankumawat.github.io/LearnCPP/
MIT License
647 stars 493 forks source link

📄README #6

Closed Lakhankumawat closed 2 years ago

Lakhankumawat commented 3 years ago

Aim

apeksha235 commented 3 years ago

Can I work on this?

Lakhankumawat commented 3 years ago

Sure go ahead

n4i9kita commented 2 years ago

Hi @Lakhankumawat. Can I work on this?

Also, why have we made a folder named Day-100, and there added the algorithms? Shouldn't we make folders directly for BackTracking, DP, Graphs, Greedy and so on, and add the algorithms there?

If I am understanding it correctly, then we need to add a readme.md for every 'ds or algo' related folder, to describe the concept, and also what is there (the ds and the problems discussed) in that dir?

Lakhankumawat commented 2 years ago

Yaa actually i made the algorithms folder inside and i had to migrate it to out side where as you said

Shouldn't we make folders directly for BackTracking, DP, Graphs, Greedy and so on, and add the algorithms there?

Also

we need to add a readme.md for every 'ds or algo' related folder, to describe the concept, and also what is there (the ds and the problems discussed) in that dir?

I agree with you and i think you have enough idea , you can go ahead and work on this issue , but commit less at a time and then pr , if you do more number of commits at a time it will be difficult for your valuation .

n4i9kita commented 2 years ago

Okay. Sure. I will start working on it.

These are steps I will follow while making commits.

  1. Organize all the cpp files into proper folders.
  2. Add readme to all the folders.
  3. I will use what others have contributed to the readme's earlier, and add just most important stuff - DS used, the problems we are handing within that folder, make a proper structure so that anyone in future can easily make edits to the readme's when they will add code files in the respective folders.
  4. Then, I will write DS explanations.
  5. Based on the problems or algorithms that we have covered up to now, I will write code explanation and pseudocodes of those that I can do on my level best.

Does it seem like a good plan to follow?

Lakhankumawat commented 2 years ago

Yeah sounds great , but make sure you don't run into any conflicts while merging PR , take your time and do it as you wish .

Lakhankumawat commented 2 years ago

Also if I am impressed by your contribution I will try to increase the level of PR through which you can get more points , at the end , so best of lucks .

n4i9kita commented 2 years ago

Sure.

(Reorganizing the folder structure is the first step; then I will all readme to all folders)

n4i9kita commented 2 years ago

Okay

n4i9kita commented 2 years ago

I have been working on main branch till now. Considering to move to another branch. @Lakhankumawat recommendations.

Lakhankumawat commented 2 years ago

yea, sure you can continue with new branch

Anjali-Chaudhary3 commented 2 years ago

Can i also contribute here? @Lakhankumawat

Lakhankumawat commented 2 years ago

Can i also contribute here? @Lakhankumawat Sure but contribute after the meet beacuse some of the things will be discussed tomorrow , find the details inside REPO's README

n4i9kita commented 2 years ago

@Anjali-Chaudhary3 if you plan to contribute, then it would be good if we can co-ordinate. It would be better to avoid any form of conflicts.

Anjali-Chaudhary3 commented 2 years ago

Yes .....why not.....then only the things will come out good

n4i9kita commented 2 years ago

@Anjali-Chaudhary3 hope to see you in the meet today. After that, we will decide how to go about it.

Anjali-Chaudhary3 commented 2 years ago

yes

On Mon, 28 Feb 2022 at 10:41, Nikita Sharma @.***> wrote:

@Anjali-Chaudhary3 https://github.com/Anjali-Chaudhary3 hope to see you in the meet today. After that, we will decide how to go about it.

— Reply to this email directly, view it on GitHub https://github.com/Lakhankumawat/LearnCPP/issues/6#issuecomment-1053896699, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXBXXH3P4SK3HHZWH3F7UEDU5L7XRANCNFSM42GICPAQ . You are receiving this because you were mentioned.Message ID: @.***>

Avik-creator commented 2 years ago

Hey everyone I want to contribute to it so would you like to assign this issue to me. I will learn C++ with this also as I am highly interested it learning C++.

DlVYANSH commented 2 years ago

@Lakhankumawat Hi! I am contributor in gssoc'22. Can I contribute to it? I know c++ and beginner in data structures and algorithms

@n4i9kita I am a beginner in opensource I will get to learn a lot in this please let me in.

n4i9kita commented 2 years ago

@DlVYANSH the issues that you have raised earlier, have you sent a PR for them? And, have they been reviewed yet?

@Avik-creator @DlVYANSH, you have to be specific in what you want to contribute in the README sections.

Avik-creator commented 2 years ago

I would like to add in readme what can we do with c++ and why do we need it. @n4i9kita

DlVYANSH commented 2 years ago

@DlVYANSH the issues that you have raised earlier, have you sent a PR for them? And, have they been reviewed yet?

@Avik-creator @DlVYANSH, you have to be specific in what you want to contribute in the README sections.

@n4i9kita Yes ma'am i have sent a pr for the issue and it got reviewed. It got tag of next review needed i have updated the pr yesterday morning itself but it didn't got reviewed yet.

Anjali-Chaudhary3 commented 2 years ago

@n4i9kita can I add a readme file for binary search ? I have started my open source journey under gssoc'22 ( so quite confused )

n4i9kita commented 2 years ago

@Anjali-Chaudhary3, You will have to create an issue first. Mention the plan that you will follow, and then we will decide to assign you the issue or not. See this for reference.

Anjali-Chaudhary3 commented 2 years ago

Yes ,@n4i9kita can you plz check my first issue I have made for adding the readme for binary search