search

Lakion / CmsPlugin

Simple CMS on top of SymfonyCMF for Sylius applications.
http://lakion.com
26 stars 20 forks source link

[WIP] Rename to CmsPlugin + maintenance #45

Closed NoResponseMate closed 7 years ago

NoResponseMate commented 7 years ago

Replaces #41

stefandoorn commented 7 years ago

I also tried to address this issue earlier (https://github.com/Sylius/Sylius/issues/7851#event-1021993142): isn't calling the repo 'cms-plugin' confusing? Due to that, nowhere you will figure out based on naming that it's a plugin specific for Sylius besides the composer type inside composer.json (sylius-plugin). Doesn't it make more sense to go with 'sylius-cms-plugin'? It both takes away from bundle to plugin and still makes clear it's for Sylius. The vendor shows it's not related to Sylius itself.

NoResponseMate commented 7 years ago

@stefandoorn Yeah I was against it as well, but I guess this convention is not that bad, since type and keywords are a thing, but on first glance at the repo/package you just can't know what it can be used for.

And since the convention is still somewhat young, so maybe with enough people making a fuss we can pass another decree reverting this 😉