search

Lakion / CmsPlugin

Simple CMS on top of SymfonyCMF for Sylius applications.
http://lakion.com
26 stars 20 forks source link

Compatible with return types, PHP 7.1 & Sylius 1.0 (fixes #60) #64

Closed stefandoorn closed 6 years ago

stefandoorn commented 7 years ago

Make CmsPlugin compatible with latest version of Sylius (especially that 1.0 is getting close).

michalmarcinkowski commented 6 years ago

Hi Stefan, could you update travis config to only run tests for PHP 7.1 and modify composer to allow for Sylius 1.0, so we can see if we need any more codebase updates to be compatible with stable release?

stefandoorn commented 6 years ago

@michalmarcinkowski This should do it, I think.

michalmarcinkowski commented 6 years ago

Thanks Stefan! 👍 Looks good! 🏅

stefandoorn commented 6 years ago

Can we also have a release tagged maybe that's 1.0 supported? Or do you want to wait for more testing? I'm in my free time upgrading a project to 1.0 in which it seemed to work with my latest PR.

michalmarcinkowski commented 6 years ago

Released v1.0.0-beta, after some time if there will be no issues we can tag v1.0 stable 😉