search

Lakion / CmsPlugin

Simple CMS on top of SymfonyCMF for Sylius applications.
http://lakion.com
26 stars 20 forks source link

jackalope/jackalope-doctrine-dbal #66

Open kochen opened 6 years ago

kochen commented 6 years ago

the package is set in the require-dev section, but mentioned in the README as a step you should do.

I'd move it into the suggest section of composer or make it part of the actual requirements and remove it from the steps as it'd be installed with the plugin.

@michalmarcinkowski thoughts?

michalmarcinkowski commented 6 years ago

I believe it's used by our test suite, so removing it from require-dev would break tests. Have you checked this?

ElectricMaxxx commented 6 years ago

In general you should requiere phpcr/implementation as an virtual package and then give the user the chance to use dbal or jackrabit. So having it in require-dev is fine.