search

Lakion / SyliusElasticSearchBundle

ElasticSearch integration with advanced filtering options for Sylius eCommerce applications.
21 stars 44 forks source link

Migrate the Elastica Grid driver from Sylius/Sylius PR #1

Open pjedrzejewski opened 7 years ago

pjedrzejewski commented 7 years ago

@Niiko

https://github.com/Sylius/Sylius/pull/5756

We should migrate the driver here to kickstart the development of this bundle. Are you willing to submit a PR here or we somehow get your commits here?

Niiko commented 7 years ago

Yes no problem :)

pjedrzejewski commented 7 years ago

@Niiko Great, so @Arminek will setup the initial structure of this bundle, so that you can run Behat scenarios and everything and then we would need you to open your initial PR here. :) Thanks for your help!

Niiko commented 7 years ago

Perfect :)

Arminek commented 7 years ago

Hi @Niiko when #6 will be merged you can open pr with your driver and it would be great if you will apply some changes from comments here https://github.com/Sylius/Sylius/pull/5756. Also you don't have to register those services i will combine your commits with https://github.com/Lakion/SyliusElasticSearchBundle/pull/7 and make it works 🎉 .

Niiko commented 7 years ago

Hi @Arminek ok, will do that :) thanks for support

Niiko commented 7 years ago

Hi @Arminek, due to sylius issue closed, i'm a little bit confused on how to contribute.

If i'm correct, driver can still be included and has to be for grid usage no ? Otherwise we can't use it for.

Just have to make it compliant with the new engine and match method, right ?