search

Lakritzator / harmony

C# library for connecting to and controlling the Logitech Harmony Hub.
MIT License
5 stars 0 forks source link

Rename HarmonyClient to Client #15

Closed Slion closed 8 years ago

Slion commented 8 years ago

Since it's already in the HarmonyHub namspace.

Lakritzator commented 8 years ago

I am against it, this doesn't read well: var client = new Client(username, password);

The namespace is in the usings, not in the code.

Slion commented 8 years ago

Well in large projects you can't keep adding using directive all over the place. If you do using HarmonyHub you are usually in small tiny project like HarmonyDemo and there it reads well because you are just in the HarmonyHub context.

In larger project you just don't add using directive and go for HarmonyHub.Client.

Slion commented 8 years ago

Also you either use namespace and don't use prefix or the other way around but not both.

Slion commented 8 years ago

Done.

Lakritzator commented 8 years ago

Horrible... I still don't know what it brings... typing 7 chars less, but not being able to see what is initiated.