search

Lalelulilulela / pe

0 stars 0 forks source link

No warning when the data file is corrupted #3

Open Lalelulilulela opened 6 months ago

Lalelulilulela commented 6 months ago

When a user edits the data file with invalid inputs such as changing the name from Alex Yeoh to Alex Yeoh____:

image.png

The app is launched with an empty contact list without any warning shown:

image.png

Executing a command would then cause the data to be wiped when the data could potentially be recovered, inconveniencing users.

soc-pe-bot commented 6 months ago

Team's Response

image.png

As stated in our DG, deleting or editing data directly from the json file will corrupt it and hence, it causes the application to restart the data(making it empty) so that it would work without crashing.

Since its working as intended and stated, we should not get penalized for it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While this is mentioned in the DG, it is not made clear to normal users in the UG. An error message warning users of the corrupted file could possibly be shown to them such that they are aware of the consequences of proceeding as usual. Hence, this is a valid feature flaw which should not be rejected.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]