Open Lalelulilulela opened 6 months ago
This was a design choice made by our team as duplicate clients with similar policies would confuse the user.
Ensuring that the user sets contact names with unique identifiers increases clarity and reduces confusion. The user is also able to find both clients using the find command, not affecting convenience.
For future versions, we are looking to use phone number and email as a primary key for clients.
Team chose [response.Rejected
]
Reason for disagreement: While it is already mentioned in the UG that duplicate names are not allowed and that this is your team's design choice, this is still a valid feature flaw. It is more likely for a users client to have the same name as compared to having to same email or phone number. Hence, this duplicate detection feature can be improved by changing the way duplicate contacts are detected to further enhance user experience and this is a valid FeatureFlaw
that should not be rejected
.
Many clients of users could potentially have the same name and by disallowing users from adding contacts with duplicate names, the utility of the app is reduced, inconveniencing users.
The app could possibly detect duplicate contacts by checking whether the phone numbers and names are the same.