search

LamaAni / postgres-xl-helm

A postgres-xl chart for helm
MIT License
9 stars 2 forks source link

GTM Proxy Service #25

Closed sstubbs closed 4 years ago

sstubbs commented 4 years ago

I noticed that the gtm proxy service svc-pxy is a LoadBalancer. Is this required? If not it's probably safer to use ClusterIP as it shouldn't be accessed remotely.

LamaAni commented 4 years ago

@sstubbs This is an oversight on my part - it was a test that should have not been committed to master. You are correct. I will add a pr to correct this once I have a bit of time.

Would you mind doing PR reviews? Since you are starting to use this, I would prefer a second look on things I put into master.

sstubbs commented 4 years ago

ok sounds good.

LamaAni commented 4 years ago

Please see PR here, I assigned you to it if thats ok. https://github.com/LamaAni/PGXL-HELM/pull/27

LamaAni commented 4 years ago

Resolved by PR.