Lambada10 / SongSync

Android app to download lyrics (.lrc files) for songs in your music library.
GNU General Public License v3.0
407 stars 15 forks source link

Fails to download all remaining lyrics upon app aspect ratio change. #61

Open u12bdragon opened 4 months ago

u12bdragon commented 4 months ago

When app is in splitscreen mode with another app on the left/right, or is in pop-up (floating on top) mode, and you resize it, it fails to find the rest of the lyrics in batch download mode, immediately.

Steps to reproduce the behavior: 1) Put app in splitscreen or pop-up mode via "recents" navbar button. 2) Start batch download of lyrics. 3) Change aspect ratio of app. 4) Lyric downloading fails.

The expected behavior is that nothing should happen, as I'm not closing the app.

Samsung Tab S7 + Android 13 v3.0.1

pdimu commented 2 months ago

The dialog before batch downloading for lyrics says clearly not to close the app, and I guess split screen is included, as performing actions on another app while you're downloading the lyrics puts SongSync to run into background (but still have a window of it so you can see what happens and quickly do something between two apps) which is similar to closing the app and leaving it running in the background. Aka the error is caused by leaving the app (and my theory on the split screen is pretty accurate, so don't tell me you didn't leave the app)