search

LambdAurora / AurorasDecorations

Decorations-focused Quilt mod.
https://lambdaurora.dev/AurorasDecorations
GNU Lesser General Public License v3.0
50 stars 15 forks source link

Fix sawmill blade spining in the wrong direction (MC-190774) #2

Open EcoBuilder13 opened 3 years ago

EcoBuilder13 commented 3 years ago

This fixes MC-190774 for the sawmill. Prior to this commit the blade spins the opposite direction on the other side of the sawmill. This pull request fixes that.

EcoBuilder13 commented 3 years ago

Also a small note is that the sawmill spins in the opposite direction as the stonecutter. This may be intentional or not but I have left it as is for you to decide.

LucilleTea commented 3 years ago

This bug is marked as fixed in 21w13a, and this mod is now updated to 21w14a, so the PR no longer applies. Though I'm not sure such a fix makes sense for Aurora's Decorations anyway?

EcoBuilder13 commented 3 years ago

@LucilleTea This only fixes the Sawmill added by AurorasDecorations. The original bug is caused by the saw texture being improperly flipped when it is uv mapped in the model. I pulled the new model out of the 21w13a jar and I can confirm that what they did to fix it was change the x1 and x2 values because it was forgotten to be flipped on the opposite side. If you look at the difference in that commit you will see I applied the fix to the sawmill's model. The bug is present in the model since it just uv maps the saw texture onto the location specified. So when the model was made the saw blade was not flipped just like what happened in the vanilla game with the stonecutter. So I have simply just fixed that.

LucilleTea commented 3 years ago

Oh I am a dummy, good context :p

LambdAurora commented 3 years ago

The author of the sawmill model considers that the sawmill has twin blades which rotates in different directions.

EcoBuilder13 commented 3 years ago

I've changed the direction of the saw in the model to match the saw on the stonecutter. This can be reverted if you want it to spin the opposite direction or if the blades spinning in opposite directions on different sides of the sawmill the pull request can be closed.