Incompatibility with Immersive Weathering

foul-fortune-feline commented 2 years ago

From what I can tell aurora's decorations' wood type registry attempts to read the light level of charred wood, which is dependent on the individual instance, and as a result crashes the game when it passes air.

Potential solutions:

carve out a specific exception for immersive weathering's charred wood
add a config option to ignore certain wood types and/or mods


[14:32:25] [main/INFO]: Loading Minecraft 1.18.2 with Quilt Loader 0.16.1
[14:32:25] [main/INFO]: Loading 70 mods:
    - aurorasdeco 1.0.0+1.18
    - cloth-basic-math 0.6.1
    - cloth-config 6.2.62
    - immersive_weathering 2.5.6
    - java 17
    - minecraft 1.18.2
    - quilt_base 1.1.0-beta.19+1.18.2
    - quilt_biome 1.1.0-beta.19+1.18.2
    - quilt_block_extensions 1.1.0-beta.19+1.18.2
    - quilt_client_command 1.1.0-beta.19+1.18.2
    - quilt_command 1.1.0-beta.19+1.18.2
    - quilt_crash_info 1.1.0-beta.19+1.18.2
    - quilt_dimension 1.1.0-beta.19+1.18.2
    - quilt_item_group 1.1.0-beta.19+1.18.2
    - quilt_item_setting 1.1.0-beta.19+1.18.2
    - quilt_lifecycle_events 1.1.0-beta.19+1.18.2
    - quilt_loader 0.16.1
    - quilt_networking 1.1.0-beta.19+1.18.2
    - quilt_recipe 1.1.0-beta.19+1.18.2
    - quilt_registry 1.1.0-beta.19+1.18.2
    - quilt_registry_entry_attachments 1.1.0-beta.19+1.18.2
    - quilt_resource_loader 1.1.0-beta.19+1.18.2
    - quilt_screen 1.1.0-beta.19+1.18.2
    - quilt_tags 1.1.0-beta.19+1.18.2
    - quilt_tooltip 1.1.0-beta.19+1.18.2
    - quilted_fabric_api 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_api_base 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_api_lookup_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_biome_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_blockrenderlayer_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_command_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_commands_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_containers_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_content_registries_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_convention_tags_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_crash_report_info_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_dimensions_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_entity_events_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_events_interaction_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_events_lifecycle_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_game_rule_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_item_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_item_groups_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_key_binding_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_keybindings_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_lifecycle_events_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_loot_api_v2 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_loot_tables_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_mining_level_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_models_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_networking_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_networking_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_object_builder_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_particles_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_registry_sync_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_renderer_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_renderer_indigo 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_renderer_registries_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_rendering_data_attachment_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_rendering_fluids_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_rendering_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_rendering_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_resource_conditions_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_resource_loader_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_screen_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_screen_handler_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_textures_v0 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_transfer_api_v1 1.0.0-beta.22+0.56.0-1.18.2
    - quilted_fabric_transitive_access_wideners_v1 1.0.0-beta.22+0.56.0-1.18.2
    - terraform-wood-api-v1 3.0.0
[14:32:25] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/home/foul-fortune-feline/.local/share/multimc/libraries/net/fabricmc/sponge-mixin/0.11.2+mixin.0.8.5/sponge-mixin-0.11.2+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT
[14:32:25] [main/INFO]: Compatibility level set to JAVA_16
[14:32:25] [main/INFO]: Compatibility level set to JAVA_17
[14:32:28] [main/INFO]: [Quilt Command] Networking support is enabled
[14:32:29] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[14:32:30] [Render thread/INFO]: Setting user: foulfortunfeline
[14:32:30] [Render thread/ERROR]: No data fixer registered for falling_icicle
[14:32:30] [Render thread/ERROR]: No data fixer registered for falling_ash
[14:32:30] [Render thread/ERROR]: No data fixer registered for falling_sand_layer
[14:32:30] [Render thread/ERROR]: No data fixer registered for falling_leaf_layer
---- Minecraft Crash Report ----
// You should try our sister game, Minceraft!

Time: 6/21/22, 2:32 PM
Description: Initializing game

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'immersive_weathering'!
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$2(EntrypointUtils.java:62)
    at org.quiltmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:60)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invokeContainer(EntrypointUtils.java:45)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:32)
    at org.quiltmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
    at net.minecraft.class_310.<init>(class_310.java:452)
    at net.minecraft.client.main.Main.main(Main.java:197)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:423)
    at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:76)
    at org.quiltmc.loader.launch.knot.KnotHelper.launchClient(KnotHelper.java:28)
    at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:23)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.IllegalArgumentException: Cannot get property class_2746{name=smoldering, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{minecraft:air}
    at net.minecraft.class_2688.method_11654(class_2688.java:98)
    at com.ordana.immersive_weathering.registry.blocks.ModBlocks.lambda$createLightLevelFromSmolderingBlockState$4(ModBlocks.java:221)
    at net.minecraft.class_4970$class_4971.<init>(class_4970.java:670)
    at net.minecraft.class_2680.<init>(class_2680.java:17)
    at net.minecraft.class_2689.method_28484(class_2689.java:61)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at net.minecraft.class_2689.<init>(class_2689.java:59)
    at net.minecraft.class_2689$class_2690.method_11668(class_2689.java:157)
    at net.minecraft.class_2248.<init>(class_2248.java:185)
    at net.minecraft.class_2237.<init>(class_2237.java:15)
    at dev.lambdaurora.aurorasdeco.block.ShelfBlock.<init>(ShelfBlock.java:80)
    at dev.lambdaurora.aurorasdeco.registry.AurorasDecoRegistry.lambda$init$22(AurorasDecoRegistry.java:786)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.onWoodTypeModified(WoodType.java:159)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.addComponent(WoodType.java:150)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.onBlockRegister(WoodType.java:212)
    at dev.lambdaurora.aurorasdeco.registry.AurorasDecoRegistry.lambda$init$17(AurorasDecoRegistry.java:686)
    at org.quiltmc.qsl.registry.impl.event.RegistryMonitorImpl.lambda$forUpcoming$1(RegistryMonitorImpl.java:78)
    at net.minecraft.class_2378.mde7fecd$lambda$new$0$2(class_2378.java:610)
    at net.minecraft.class_2370.handler$zco000$quilt$invokeEntryAddEvent(class_2370.java:1056)
    at net.minecraft.class_2370.method_31051(class_2370.java:129)
    at net.minecraft.class_2370.method_10273(class_2370.java:86)
    at net.minecraft.class_2348.method_10273(class_2348.java:24)
    at net.minecraft.class_2370.method_10272(class_2370.java:134)
    at net.minecraft.class_2378.method_39197(class_2378.java:471)
    at net.minecraft.class_2378.method_10230(class_2378.java:467)
    at com.ordana.immersive_weathering.registry.blocks.ModBlocks.registerBlocks(ModBlocks.java:292)
    at com.ordana.immersive_weathering.ImmersiveWeathering.onInitialize(ImmersiveWeathering.java:47)
    at org.quiltmc.loader.impl.game.minecraft.Hooks.lambda$startClient$0(Hooks.java:52)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke$0(EntrypointUtils.java:32)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:58)
    ... 21 more

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$2(EntrypointUtils.java:62)
    at org.quiltmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:60)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invokeContainer(EntrypointUtils.java:45)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:32)
    at org.quiltmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
    at net.minecraft.class_310.<init>(class_310.java:452)

-- Initialization --
Details:
    Modules: 
Stacktrace:
    at net.minecraft.client.main.Main.main(Main.java:197)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:423)
    at net.fabricmc.loader.launch.knot.Knot.launch(Knot.java:76)
    at org.quiltmc.loader.launch.knot.KnotHelper.launchClient(KnotHelper.java:28)
    at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:23)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)

-- System Details --
Details:
    Minecraft Version: 1.18.2
    Minecraft Version ID: 1.18.2
    Operating System: Linux (amd64) version 5.17.5-76051705-generic
    Java Version: 17.0.3, Private Build
    Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Private Build
    Memory: 1191941120 bytes (1136 MiB) / 2919235584 bytes (2784 MiB) up to 6291456000 bytes (6000 MiB)
    CPUs: 12
    Processor Vendor: AuthenticAMD
    Processor Name: AMD Ryzen 5 3600 6-Core Processor
    Identifier: AuthenticAMD Family 23 Model 113 Stepping 0
    Microarchitecture: Zen 2
    Frequency (GHz): -0.00
    Number of physical packages: 1
    Number of physical CPUs: 6
    Number of logical CPUs: 12
    Graphics card #0 name: Navi 14 [Radeon RX 5500/5500M / Pro 5500M]
    Graphics card #0 vendor: Advanced Micro Devices, Inc. [AMD/ATI] (0x1002)
    Graphics card #0 VRAM (MB): 258.00
    Graphics card #0 deviceId: 0x7340
    Graphics card #0 versionInfo: unknown
    Virtual memory max (MB): 8005.88
    Virtual memory used (MB): 6967.57
    Swap memory total (MB): 0.00
    Swap memory used (MB): 0.00
    JVM Flags: 2 total; -Xms409m -Xmx6000m
    Quilted Fabric API: !! WARNING !! This instance is using Fabric API modules re-implemented by QSL. If the issue comes from Quilted Fabric API, DO NOT report to Fabric; report them to Quilt instead!
    Quilt Mods: 
        aurorasdeco: Aurora's Decorations 1.0.0+1.18
        cloth-basic-math: cloth-basic-math 0.6.1
        cloth-config: Cloth Config v6 6.2.62
        immersive_weathering: Immersive Weathering 2.5.6
        java: OpenJDK 64-Bit Server VM 17
        minecraft: Minecraft 1.18.2
        quilt_base: Quilt Base API 1.1.0-beta.19+1.18.2
        quilt_biome: Quilt Biome API 1.1.0-beta.19+1.18.2
        quilt_block_extensions: Quilt Block Extensions API 1.1.0-beta.19+1.18.2
        quilt_client_command: Quilt Client Command API 1.1.0-beta.19+1.18.2
        quilt_command: Quilt Command API 1.1.0-beta.19+1.18.2
        quilt_crash_info: Quilt Crash Info 1.1.0-beta.19+1.18.2
        quilt_dimension: Quilt Dimension API 1.1.0-beta.19+1.18.2
        quilt_item_group: Quilt Item Group API 1.1.0-beta.19+1.18.2
        quilt_item_setting: Quilt Item Setting API 1.1.0-beta.19+1.18.2
        quilt_lifecycle_events: Quilt Lifecycle Events 1.1.0-beta.19+1.18.2
        quilt_loader: Quilt Loader 0.16.1
        quilt_networking: Quilt Networking 1.1.0-beta.19+1.18.2
        quilt_recipe: Quilt Recipe API 1.1.0-beta.19+1.18.2
        quilt_registry: Quilt Registry API 1.1.0-beta.19+1.18.2
        quilt_registry_entry_attachments: Quilt Registry Entry Attachments 1.1.0-beta.19+1.18.2
        quilt_resource_loader: Quilt Resource Loader 1.1.0-beta.19+1.18.2
        quilt_screen: Quilt Screen API 1.1.0-beta.19+1.18.2
        quilt_tags: Quilt Tags API 1.1.0-beta.19+1.18.2
        quilt_tooltip: Quilt Tooltip API 1.1.0-beta.19+1.18.2
        quilted_fabric_api: Quilted Fabric API 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_api_base: Quilted Fabric API Base 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_api_lookup_api_v1: Quilted Fabric API Lookup API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_biome_api_v1: Quilted Fabric Biome API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_blockrenderlayer_v1: Quilted Fabric BlockRenderLayer Registration (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_command_api_v1: Quilted Fabric Command API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_commands_v0: Quilted Fabric Commands (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_containers_v0: Quilted Fabric Containers (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_content_registries_v0: Quilted Fabric Content Registries (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_convention_tags_api_v1: Quilted Fabric Convention Tags API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_crash_report_info_v1: Quilted Fabric Crash Report Info (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_dimensions_v1: Quilted Fabric Dimensions API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_entity_events_v1: Quilted Fabric Entity Events (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_events_interaction_v0: Quilted Fabric Events Interaction (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_events_lifecycle_v0: Quilted Fabric Events Lifecycle (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_game_rule_api_v1: Quilted Fabric Game Rule API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_item_api_v1: Quilted Fabric Item API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_item_groups_v0: Quilted Fabric Item Groups (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_key_binding_api_v1: Quilted Fabric Key Binding API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_keybindings_v0: Quilted Fabric Key Bindings (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_lifecycle_events_v1: Quilted Fabric Lifecycle Events (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_loot_api_v2: Quilted Fabric Loot API (v2) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_loot_tables_v1: Quilted Fabric Loot Tables (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_mining_level_api_v1: Quilted Fabric Mining Level API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_models_v0: Quilted Fabric Models (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_networking_api_v1: Quilted Fabric Networking API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_networking_v0: Quilted Fabric Networking (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_object_builder_api_v1: Quilted Fabric Object Builder API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_particles_v1: Quilted Fabric Particles (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_registry_sync_v0: Quilted Fabric Registry Sync (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_renderer_api_v1: Quilted Fabric Renderer API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_renderer_indigo: Quilted Fabric Renderer - Indigo 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_renderer_registries_v1: Quilted Fabric Renderer Registries (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_rendering_data_attachment_v1: Quilted Fabric Rendering Data Attachment (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_rendering_fluids_v1: Quilted Fabric Rendering Fluids (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_rendering_v0: Quilted Fabric Rendering (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_rendering_v1: Quilted Fabric Rendering (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_resource_conditions_api_v1: Quilted Fabric Resource Conditions API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_resource_loader_v0: Quilted Fabric Resource Loader (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_screen_api_v1: Quilted Fabric Screen API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_screen_handler_api_v1: Quilted Fabric Screen Handler API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_textures_v0: Quilted Fabric Textures (v0) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_transfer_api_v1: Quilted Fabric Transfer API (v1) 1.0.0-beta.22+0.56.0-1.18.2
        quilted_fabric_transitive_access_wideners_v1: Quilted Fabric Transitive Access Wideners (v1) 1.0.0-beta.22+0.56.0-1.18.2
        terraform-wood-api-v1: Terraform Wood API (v1) 3.0.0
    Launched Version: 1.18.2
    Backend library: LWJGL version 3.2.2 build 10
    Backend API: Unknown
    Window size: <not initialized>
    GL Caps: Using framebuffer using OpenGL 3.2
    GL debug messages: <disabled>
    Using VBOs: Yes
    Is Modded: Definitely; Client brand changed to 'quilt'
    Type: Client (map_client.txt)
    CPU: <unknown>```

LambdAurora commented 2 years ago

I have to resist the urge to write my own BlockState implementation.

LambdAurora commented 2 years ago

Oh and, it's not air, it's a charred shelf block that fail to copy the settings, and since it's not registered yet, well, it returns air for the identifier.

foul-fortune-feline commented 2 years ago

Nvm, I fixed it on IW's side

LambdAurora commented 2 years ago

How so?

foul-fortune-feline commented 2 years ago

Wait I thought I had lol

foul-fortune-feline commented 2 years ago

How so?

A try catch and I think it actually did fix it lol

foul-fortune-feline commented 2 years ago

A. Okay so it loads now but placing one of the items crashes the game

LambdAurora commented 2 years ago

I'm not sure this is fixable on IW's side.

The way it seems to work is it wants some properties to be a part of the block for which it gets its light provider. The ultimate issue is I don't copy those properties, and I'm not a fan of that for the wooden blocks.

So when MC is trying to construct the blockstate cache it executes the light provider from IW's on my shelf block, and crash due to it expecting the property.

Possible fixes is for me to discard any light providers.

foul-fortune-feline commented 2 years ago

Works now!

foul-fortune-feline commented 2 years ago

So basically all I did was try catch in immersive weathering, and if it tries to throw an IllegalArgumentException it instead returns that it's not smoldering + not to emit any light

LambdAurora commented 2 years ago

Not a big fan of the try catch :/

Using a contains on the BlockState properties would be cleaner.

foul-fortune-feline commented 2 years ago

You're right! I did that thing

foul-fortune-feline commented 2 years ago

https://github.com/AstralOrdana/Immersive-Weathering/pull/97

foul-fortune-feline commented 2 years ago

Works like a charm now~

Might be a good idea to run the wood thing later in the startup process if possible? Idk haha I only have so much experience modding and less with compatibility stuff

LambdAurora commented 2 years ago

No, this is not due to a "when it runs" thing.

This is just the mod blindly copying another block's settings without copying the properties too.

foul-fortune-feline commented 2 years ago

I guess there is still one (minor) problem which is that the wood type doesn't yet have a name in the lang file but that's somewhat easily fixed

foul-fortune-feline commented 2 years ago

No, this is not due to a "when it runs" thing.

This is just the mod blindly copying another block's settings without copying the properties too.

ic

foul-fortune-feline commented 2 years ago

But yea everything renders properly now

magneticflux- commented 1 year ago

Seems broken now. Versions:

|   267 | Aurora's Decorations                    | aurorasdeco                   | 1.0.0-beta.8+1.19
|    42 | Immersive Weathering                    | immersive_weathering          | 1.19.2-1.1.1
|   120 | Moonlight                               | moonlight                     | 1.19.2-2.0.40

Exception:

java.lang.RuntimeException: Could not execute entrypoint stage 'client' due to errors, provided by 'moonlight'!
    at Not Enough Crashes deobfuscated stack trace.(1.19+build.2)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$2(EntrypointUtils.java:63)
    at org.quiltmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:61)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invokeContainer(EntrypointUtils.java:46)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:33)
    at org.quiltmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
    at net.minecraft.client.MinecraftClient.<init>(MinecraftClient:459)
    at net.minecraft.client.main.Main.method_44604(Main:205)
    at net.minecraft.client.main.Main.main(Main:51)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.lang.reflect.Method.invoke(Method.java:578)
    at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:423)
    at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:76)
    at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:24)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.lang.reflect.Method.invoke(Method.java:578)
    at org.prismlauncher.impl.OneSixLauncher.invokeMain(OneSixLauncher.java:104)
    at org.prismlauncher.impl.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:176)
    at org.prismlauncher.impl.OneSixLauncher.launch(OneSixLauncher.java:186)
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:144)
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:74)
Caused by: java.lang.IllegalArgumentException: Cannot get property class_2746{name=smoldering, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{minecraft:air}
    at net.minecraft.state.State.get(State:98)
    at com.ordana.immersive_weathering.reg.ModBlocks.lambda$litLightLevel$1(ModBlocks.java:88)
    at net.minecraft.block.AbstractBlock$AbstractBlockState.<init>(AbstractBlock:691)
    at net.minecraft.block.BlockState.<init>(BlockState:17)
    at net.minecraft.state.StateManager.method_28484(StateManager:61)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1006)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1006)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1006)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
    at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    at net.minecraft.state.StateManager.<init>(StateManager:59)
    at net.minecraft.state.StateManager$Builder.build(StateManager:157)
    at net.minecraft.block.Block.<init>(Block:187)
    at net.minecraft.block.BlockWithEntity.<init>(BlockWithEntity:15)
    at dev.lambdaurora.aurorasdeco.block.ShelfBlock.<init>(ShelfBlock.java:81)
    at dev.lambdaurora.aurorasdeco.registry.AurorasDecoRegistry.lambda$init$21(AurorasDecoRegistry.java:746)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.onWoodTypeModified(WoodType.java:178)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.addComponent(WoodType.java:169)
    at dev.lambdaurora.aurorasdeco.registry.WoodType.onBlockRegister(WoodType.java:231)
    at dev.lambdaurora.aurorasdeco.registry.AurorasDecoRegistry.lambda$init$16(AurorasDecoRegistry.java:677)
    at org.quiltmc.qsl.registry.impl.event.RegistryMonitorImpl.lambda$forUpcoming$1(RegistryMonitorImpl.java:78)
    at net.minecraft.util.registry.Registry.md4c6836$lambda$new$0$4(Registry:3153)
    at net.minecraft.util.registry.SimpleRegistry.handler$hcg000$quilt$invokeEntryAddEvent(SimpleRegistry:2612)
    at net.minecraft.util.registry.SimpleRegistry.set(SimpleRegistry:130)
    at net.minecraft.util.registry.SimpleRegistry.set(SimpleRegistry:87)
    at net.minecraft.util.registry.DefaultedRegistry.set(DefaultedRegistry:24)
    at net.minecraft.util.registry.SimpleRegistry.add(SimpleRegistry:135)
    at net.mehvahdjukaar.moonlight.api.platform.fabric.RegistryQueue$EntryWrapper.initialize(RegistryQueue.java:67)
    at java.util.ArrayList.forEach(ArrayList.java:1511)
    at net.mehvahdjukaar.moonlight.api.platform.fabric.RegistryQueue.initializeEntries(RegistryQueue.java:34)
    at java.util.LinkedHashMap$LinkedValues.forEach(LinkedHashMap.java:655)
    at net.mehvahdjukaar.moonlight.api.platform.fabric.RegHelperImpl.registerEntries(RegHelperImpl.java:65)
    at net.mehvahdjukaar.moonlight.fabric.MoonlightFabric.commonSetup(MoonlightFabric.java:38)
    at net.mehvahdjukaar.moonlight.fabric.MoonlightFabricClient.onInitializeClient(MoonlightFabricClient.java:12)
    at org.quiltmc.loader.impl.game.minecraft.Hooks.lambda$startClient$1(Hooks.java:53)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke$0(EntrypointUtils.java:33)
    at org.quiltmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:59)
    ... 18 more

Sunconure11 commented 1 year ago

Can confirm. @LambdAurora

https://pastebin.com/YWqPPFSq

LambdAurora / AurorasDecorations

Incompatibility with Immersive Weathering #28