search

LambdAurora / AurorasDecorations

Decorations-focused Quilt mod.
https://lambdaurora.dev/AurorasDecorations
GNU Lesser General Public License v3.0
50 stars 15 forks source link

[1.19.2] Incompatible with Vinery #43

Open SleepyEmber opened 1 year ago

SleepyEmber commented 1 year ago

I need to try this isolated as well, but after some testing, Aurora's Decorations seems to be incompatible with Vinery https://paste.ee/p/v91AN https://www.curseforge.com/minecraft/mc-mods/lets-do-wine

Sunconure11 commented 1 year ago

Have this issue too. @LambdAurora

Sunconure11 commented 1 year ago

Found the class that is probably conflicting.

https://github.com/satisfyu/Vinery/blob/e9c98dbdf2051158b45deebfcf088b753d7c5637/common/src/main/java/satisfyu/vinery/block/StackableLogBlock.java#L38

Sunconure11 commented 1 year ago

https://pastebin.com/3kyAjsN1

Forgot to post a fresh crash report

SplendidAlakey commented 1 year ago

The mods are compatible on 1.20.x now, but I'm not sure which side is responsible and if the changes could be backported.

Sunconure11 commented 1 year ago

Yeah, I saw that they are on 1.20.x and 1.19.4 now. However, I can't close this issue so I will leave it up to @LambdAurora to decide if they want to backport the fix or not, and if they want to close this issue.

LambdAurora commented 1 year ago

ngl, I don't like backporting stuff.

Sunconure11 commented 1 year ago

Alright, can you close this issue then?