search

LambdAurora / AurorasDecorations

Decorations-focused Quilt mod.
https://lambdaurora.dev/AurorasDecorations
GNU Lesser General Public License v3.0
50 stars 15 forks source link

Optimise ModelLoaderMixin #46

Closed AlexIIL closed 1 year ago

AlexIIL commented 1 year ago

By replacing List.contains with Set.contains.

I encountered this by testing @SplendidAlakey s pack https://github.com/SplendidAlakey/Perfectly-Splendid, and I noticed that 12s of loading time is spent in ArrayList.contains in this method - so this PR should speed that up?

(Draft because I haven't tested this yet)

LambdAurora commented 1 year ago

I think even with an unlinked hash set it should speed up, can't believe I forgot my own benchmark table too.