search

LambdAurora / AurorasDecorations

Decorations-focused Quilt mod.
https://lambdaurora.dev/AurorasDecorations
GNU Lesser General Public License v3.0
50 stars 15 forks source link

Bookpiles placed by other players are invisible #5

Closed EcoBuilder13 closed 3 years ago

EcoBuilder13 commented 3 years ago

image When another player places a book or enchanted book it is invisible to other players and can not be fixed by disconnecting and reconnecting to the server. The players can collide with the books and break them but not see them. This was tested on a dedicated server. Minecraft: 21w15a AurorasDecorations: 669c98267a1eaaec1aaf72b788d0b24235412108

LambdAurora commented 3 years ago

That is odd, it happens directly when you place the book?

I currently don't have a test server for 21w15a so not sure what's going on. Let's hope that it's just the renderer that broke and not serialization/networking again.

EcoBuilder13 commented 3 years ago

It happens when anyone other than you places a book. Books you place can go invisible too, I discovered that later without unloading the chunks. It might be the game stops rendering them and when they load back in they don't check their coordinates to see what color they are. Since books determine their texture based on their coordinates, they are always the same in the same block. So it may fail to check so it can determine the texture unless if it is newly placed.

LambdAurora commented 3 years ago

It sounds a lot like the behavior before 669c982, I would suggest to reclone and recompile just to be sure.

EcoBuilder13 commented 3 years ago

It looks like I accidentally copied the wrong jar file. The books work properly with 611b2d070c2f2b7717c0d6ef1f4151f4b9905bd2, so I was just missing where you fixed the NBT methods being backwards in 669c98267a1eaaec1aaf72b788d0b24235412108.