Painter's Palette (`NestedScreenHandler`) causes crash after `CloseHandledScreenC2SPacket` handling fails

[sisby-folk]

Hi hello! I'm forwarding through a crash I've had reported on a 1.19.2 Tinkerer's Quilt server. We tested the painter's palette in singleplayer a good bit so I'm assuming this is a dedicated server only issue.

It seems to be an "after a while" crash that doesn't interrupt actually using the painter's palette correctly, just occurs after a bit of using it? kind of weird.

It's also possible it's an incompatibility, but we'll have more information once it's been reproduced a little more.

    [22:29:07] [Server thread/ERROR]: Failed to handle packet net.minecraft.class_2815@39d78540, suppressing error
java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 36
    at java.util.Arrays$ArrayList.get(Arrays.java:4165) ~[?:?]
    at net.minecraft.class_2371.get(class_2371.java:47) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_1661.method_5438(class_1661.java:503) ~[transformed-mod-minecraft.i0:0/:?]
    at dev.lambdaurora.aurorasdeco.screen.NestedScreenHandler.method_7595(NestedScreenHandler.java:69) ~[transformed-mod-aurorasdeco.i0:0/:?]
    at net.minecraft.class_3222.method_14247(class_3222.java:1094) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_3244.method_12054(class_3244.java:1736) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_2815.method_12198(class_2815.java:15) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_2815.method_11054(class_2815.java:6) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_2600.method_11072(class_2600.java:22) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_3738.run(class_3738.java:18) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_1255.method_18859(class_1255.java:157) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:776) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:159) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_1255.method_16075(class_1255.java:131) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:758) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:752) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.class_1255.method_5383(class_1255.java:116) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:736) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.handler$bon000$carpet$modifiedRunLoop(MinecraftServer.java:7394) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:644) ~[transformed-mod-minecraft.i0:0/:?]
    at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[transformed-mod-minecraft.i0:0/:?]
    at java.lang.Thread.run(Thread.java:833) [?:?]
[22:29:10] [Server thread/ERROR]: Failed to handle packet net.minecraft.class_2815@2c54bcca, suppressing error
java.lang.ArrayIndexOutOfBoundsException: null

and then after a few more of those suppressed errors, eventually...

    [22:30:30] [Server thread/ERROR]: Encountered an unexpected exception
java.lang.ArrayIndexOutOfBoundsException: null
[22:30:31] [Server thread/ERROR]: This crash report has been saved to: /home/********/Desktop/Tinkerer's Quilt Plus (1.19) Server/server/./crash-reports/crash-2023-06-14_22.30.31-server.txt