LambdAurora / LambDynamicLights

A dynamic lighting mod for Minecraft on Fabric Loader.
https://lambdaurora.dev/projects/lambdynamiclights/
Other
411 stars 98 forks source link

Improve "Fantastic"-tier effect at high framerates #105

Closed sisby-folk closed 2 years ago

sisby-folk commented 2 years ago

Is your feature request related to a problem? Please describe. I'm running on a 144hz display and this mod doesn't appear to update every frame, causing an apparent stutter that's visually quite painful (at least for me personally)

Describe the solution you'd like I'm not familiar enough with the exact mechanic that causes the discomfort (I'm only assuming it's frame timing), but the two performance modes don't have this problem (as they already update less than every frame, even for 60hz)

Describe alternatives you've considered Shaders don't seem to have this problem as they're running every frame, so #99 would help with this

Additional context Honestly feel free to just explain me roadblocks with this one. I'm already working around it with shaders but I like being able to turn them off, and either way I'm not getting dynamic lights at 144hz.

sisby-folk commented 2 years ago

Hey just an update on this one, I was totally talking out of my ass this is just #95

To at least provide some additional information here, here's the frame timings without holding a lantern and walking image

And here's the frame timings with holding a lantern and walking image

Finally, here it is with "Always defer chunk updates" from sodium. image

Lastly, it's worth noting that setting "always defer chunk updates" to true and "chunk update threads" > 1 causes dynamic lighting updates to stop altogether, which makes some sense as far as I understand.