search

LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
397 stars 98 forks source link

Update to 1.20 #154

Closed LukaTV939 closed 1 year ago

LukaTV939 commented 1 year ago

As the title says new version came out and old mods that are not updated don't work

lospejos commented 1 year ago

@LukaTV939 Why you tagged this issue as a bug? IMHO this is rather the feature or improvement.

LukaTV939 commented 1 year ago

@LukaTV939 Why you tagged this issue as a bug? IMHO this is rather the feature or improvement.

My bad, I was in a hurry and didn't think about it. Can I change the tag somehow?

lospejos commented 1 year ago

My bad, I was in a hurry and didn't think about it. Can I change the tag somehow?

Maybe just edit your issue. I cannot edit this since I'm not this issue's author.

mk-pmb commented 1 year ago

In case someone needs a JAR download for 1.20, here's my build of PR #156. @Lisixo, thanks a lot for providing!

Maybe just edit your issue.

I just tested with one of my own issue threads in another repo. Seems like by default, regular users cannot edit their thread's tags.

LukaTV939 commented 1 year ago

In case someone needs a JAR download for 1.20, here's my build of PR #156. @Lisixo, thanks a lot for providing!

Maybe just edit your issue.

I just tested with one of my own issue threads in another repo. Seems like by default, regular users cannot edit their thread's tags.

The release is empty :/

mk-pmb commented 1 year ago

@LukaTV939 That's odd. Maybe Github had a temporary failure? Anyway you can easily build your own, just open a repo on GitHub, import the files from my build branch, and push it to GitHub. Even if you don't set a publish token, you can still access the build artifact from your own GitHub Actions run. The artifact should work the same just the filename is wrong.

LukaTV939 commented 1 year ago

@LukaTV939 That's odd. Maybe Github had a temporary failure? Anyway you can easily build your own, just open a repo on GitHub, import the files from my build branch, and push it to GitHub. Even if you don't set a publish token, you can still access the build artifact from your own GitHub Actions run. The artifact should work the same just the filename is wrong.

Thanks, I can see there releases so it's even better

github-actions[bot] commented 1 year ago

Thanks for raising attention towards the need for a port to a Minecraft version.

Though, the author is already aware of such version, there isn't much need for further comments.
Given an annoying increase in "new version when" comments on diverse platforms, such issues won't allow comment anymore as it does not help making a faster release.

Thank you for your understanding.

NatoBoram commented 1 year ago

Thanks @LambdAurora 💙

LukaTV939 commented 1 year ago

Thanks for raising attention towards the need for a port to a Minecraft version.

Though, the author is already aware of such version, there isn't much need for further comments.
Given an annoying increase in "new version when" comments on diverse platforms, such issues won't allow comment anymore as it does not help making a faster release.

Thank you for your understanding.

I made an issue cuz the update was then like 2 months ago, plus it's only a issue and just wanted to get notified when it's closed and updated

LambdAurora commented 1 year ago

It was not that far lmao.

This system is mostly for future issues, here it only lasted a few hours as a test.