search

LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
397 stars 98 forks source link

Update to 1.20 #156

Closed Lisixo closed 1 year ago

Lisixo commented 1 year ago

Updated to Minecraft 1.20

I commented gui/SettingsScreen.java because i can't find solution for this code fragment but mod and game work fine without this code fragment

Lisixo commented 1 year ago

fillGradient adds black shadow to settings background

Latest 1.19.4 build: ss_1 19 4

1.20 build: ss_1 20

Rubyboat1207 commented 1 year ago

This works in 1.20.1, someone needs to update the mod.json though

joestr commented 1 year ago

Confirmed working on 1.20.1

mk-pmb commented 1 year ago

Can confirm, works for me for 1.20. This is my build including a JAR download for anyone else who needs one.

@Lisixo Thanks a lot!

PetyXbron commented 1 year ago

Hey @Lisixo, could this PR also support Minecraft v1.20.1? image

mk-pmb commented 1 year ago

Thanks @KennyDevT ! I restarted my build. The new JAR for 1.20.1 should be public in about 10 minutes. Edit: The new download has arrived.

KennyDevT commented 1 year ago

Honestly I just wanted to have it in my modpack I didn't even know about this PR until I decided to PR it to Lixiso fork

JanLukasGithub commented 1 year ago

Now we just need @LambdAurora (or someone else with rights to do so) to merge this and update the modrinth page, right?

mk-pmb commented 1 year ago

@JanLukasGithub I think we should wait for more people to report whether it worked for them in 1.20.1. I myself only play 1.20 currently, and I haven't seen any confirmation comments for the current commit https://github.com/LambdAurora/LambDynamicLights/pull/156/commits/fea5d26f2179cad66cc452393314326b68864f75 .

Update: fea5d26 JAR download if someone needs it. React with 🚀 if it works for you in MC 1.20.1.

TheUnknownCod3r commented 1 year ago

I know this is closed and published now, but Fabric API should be 0.83.0 if people are still using base 1.20, as most mod launchers will still serve it as the most recent version for 1.20.

LambdAurora commented 1 year ago

Well, that's one issue I just realized I forgot. The dependency should also be marked fabric-api now... oops...

Welp, I'm not fixing that now, worst case scenario there's dependency overrides, and 1.20.1 is so minor everything should work there anyway so people should just update.

MBCMechachu commented 1 year ago

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message.

Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later.

Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API'
(fabric-api), but only the wrong version is present: 0.83.0+1.20!
LambdAurora commented 1 year ago

@MBCMechachu update to 1.20.1 and update Fabric API.

1.20.1 is so minor that all mods should work and be compatible with 1.20 servers.

TheUnknownCod3r commented 1 year ago

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message.

Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later.

Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API' (fabric-api), but only the wrong version is present: 0.83.0+1.20!

You can create an overrides pack to bypass that, follow https://fabricmc.net/wiki/tutorial:dependency_overrides and just set it up for dynamic lights, or update to 1.20.1, and just copy paste everything, as it should work anyway.

MBCMechachu commented 1 year ago

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message. Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later. Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API' (fabric-api), but only the wrong version is present: 0.83.0+1.20!

You can create an overrides pack to bypass that, follow https://fabricmc.net/wiki/tutorial:dependency_overrides and just set it up for dynamic lights, or update to 1.20.1, and just copy paste everything, as it should work anyway.

A lot of this is far too complex for me to understand in order for me to do this on my own. What's worse is that I can't seem to find any sort of step by step videos anywhere so I'm just stuck having to wait until the mods I was using update to 1.20.1; assuming that some of them do at all.

Update: Turns out all I needed to do was update my Fabric API to the one for 1.20.1, everything is working fine now.

mk-pmb commented 1 year ago

Can we have the v2.3.1+1.20.1 release page have a big hint "You'll need to update Fabric API to at least x.x.x" also with a download link to that?

Edit: Maybe it would be a good idea to have a default "System Requirements" chapter as one of the first things on every release page.