LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
397 stars 98 forks source link

Incompatible With Sodium v0.5.X #175

Closed LXY4286 closed 1 year ago

LXY4286 commented 1 year ago

The mod wouldn't work with Sodium v0.5.0(the newest version of Sodium) But if I replace Sodium with v0.4, it became normal.

To reproduce it, just install it with Sodium V0.5.0

SpiritAxolotl commented 1 year ago

vouch (also you meant "incompatible")

pingouyn commented 1 year ago

Same as OP, doesn't work with sodium 0.5.0-0.5.1 but works with sodium 0.4.10.

LXY4286 commented 1 year ago

Oh, sorry. My first language is not English, and this is the first time I reflect an issue here.

Sentineluno commented 1 year ago

Happened to me too, it does seem to be sodium since after i updated it the mod stopped working properly.

ZAIAC001 commented 1 year ago

And addition to existing bug report: It works with fabric api .86 Only sodium breaks this excelent mod. Please fix it asap Your creation imao in "must have" list

(Just now try different setups. Try all fabrics api - all good. Try sodium - newest not work. For now should use oldest one)

Kichura commented 1 year ago

And addition to existing bug report: It works with fabric api .86 Only sodium breaks this excelent mod. Please fix it asap Your creation imao in "must have" list

(Just now try different setups. Try all fabrics api - all good. Try sodium - newest not work. For now should use oldest one)

Please don't pressure the devs to update the mod for you personally - Either consider waiting for it or make a pull request.

liqwang commented 1 year ago

I had the same problem, too. v2.3.1 doesn't work with Sodium v0.5.0.

iso2013 commented 1 year ago

If I'm having the same issue as everyone else, to add a bit more detail, the game launches correctly, and is playable, but blocks are not lit by dynamic lights - just items and entities.

wilebaldo commented 1 year ago

I have the same problem, in my case I play with mac and the game crash before start, but I can play one time later I closed the game but not the Launcher, I open again the game and is when is crash in the loading red minecraft screen.

I just replace the Sodium with the version 0.4.10 and now is working, but also I have to downgrade another mods need compatiblity with Sodium like, Sodium Extra, indium, Iris, reeses sodium options.

Also I got this warning all the time about Quilt Missing, but I use Fabric not Quilt.

[main/WARN]: Warnings were found!

ThatOneBonk commented 1 year ago

Same issue. Dynamic lights won't work in the world after updating to Sodium 0.5.0. The item in the hand is lit, however.

SepiaPages commented 1 year ago

Something odd I noticed is that when I hold a torch, the blocks around me don't get lit like the way it's supposed to, HOWEVER... the entities around me do. Like, the skeleton standing next to me gets lit.

Happyquack commented 1 year ago

I also noticed the lighting still working with mobs as @SepiaPages pointed out, and I tried it out with other entities and blocks. It works with other entities such as dropped items, boats, paintings, item frames, armor stands, and the player itself. Also working are signs, particles, chests, shulker boxes, bells, beds, banners, and placed heads. Not that an issue hasn't already been established - just figured I'd put this out there in case it ends up being helpful for debugging!

mdedmon commented 1 year ago

I’m running the prev version to keep it working but I noticed that torches don’t put off dynamic lighting under water. But they do outside of it. Light blocks like sea lanterns will under water. I don’t know if this is by design, but I seem to remember torches working under water.

On Sun, Aug 20, 2023 at 6:08 PM Hannah Ozello @.***> wrote:

I also noticed the lighting still working with mobs as @SepiaPages https://github.com/SepiaPages pointed out, and I tried it out with other entities and blocks. It works with other entities such as items, boats, paintings, item frames, armor stands, and the player itself. Also working are signs, particles, chests, shulker boxes, bells, beds, banners, and placed heads. Not that an issue hasn't already been established - just figured I'd put this out there in case it ends up being helpful for debugging!

— Reply to this email directly, view it on GitHub https://github.com/LambdAurora/LambDynamicLights/issues/175#issuecomment-1685408542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQEDTXMVO2ZYZJG5UQG7LXWKDD7ANCNFSM6AAAAAA3G3DXMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Thanks, Mike Dedmon Sent from my iPhone (so please forgive my brevity and spelling)

LambdAurora commented 1 year ago

I’m running the prev version to keep it working but I noticed that torches don’t put off dynamic lighting under water. But they do outside of it. Light blocks like sea lanterns will under water. I don’t know if this is by design, but I seem to remember torches working under water.

This is intended and is controlled by the water sensitivity check option.

TheChilliPL commented 1 year ago

I have the same exact issue. The torch held doesn't seem to emit any dynamic light as it should

TheChilliPL commented 1 year ago

Uh, doesn't seem to work for me even without Sodium, weird. It's all turned on in the settings

icynstant commented 1 year ago

Uh, doesn't seem to work for me even without Sodium, weird. It's all turned on in the settings

Try use Fabric API 0.85.*

LambdAurora commented 1 year ago

LambDynamicLights 2.3.2 is currently being released to fix this issue.

hoangyeager commented 7 months ago

Bản mod sẽ không hoạt động với Natri v0.5.0 (phiên bản mới nhất của Natri) Nhưng nếu tôi thay thế Natri bằng v0.4 thì nó sẽ trở lại bình thường.

Để tái tạo nó, chỉ cần cài đặt nó với Natri V0.5.0

  • Hệ điều hành: Windows 11
  • Minecraft: 1.20.1
  • Phiên bản trình tải vải: 0.14.22+build.214
  • Các mod: Fabric-api v0.86.1, lambdynamiclights v2.3.1, modmenu v7.1.0
  • Phiên bản: 2.3.1
  • Chi nhánh: mc1.20.1

What kind of download?