LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
397 stars 98 forks source link

Dynamic Light does not work when torch held on hand. #181

Closed DaGrateBot closed 1 year ago

DaGrateBot commented 1 year ago

Everything else works fine, placing the torch makes the dynamic light effect and everything, but when any light block is held on hand and I'm moving through a dark cave it does not make any light! I first though this was a mod conflict, so I made a new instance of Minecraft with only sodium and lambdynamiclights but same result?

Takedomaru commented 1 year ago

same

SANOR9000 commented 1 year ago

This mod is currently incompatible with Sodium 0.5.0/0.5.1/0.5.2 and also some versions of Fabric API. Try downgrading Sodium to 0.4.10, and if that doesn't solve it, downgrade Fabric API as well (I've only tested it with 0.83.1 and it works, but I don't know about any other version)

rowinadrian1207 commented 1 year ago

Use this datapack until Lamb fixes it, https://www.curseforge.com/minecraft/texture-packs/tschipcrafts-dynamic-lights

Etrit1 commented 1 year ago

Use this datapack until Lamb fixes it, https://www.curseforge.com/minecraft/texture-packs/tschipcrafts-dynamic-lights

Note: Datepacks are Server side things. It will not work on MultiPlayer servers unless you can get the admin to install the data pack.

There is Lucent mod if you use Forge.... but for those of us that use Fabric.. it looks like we are out of luck until this is updated.

bonkmaykrQ commented 1 year ago

Can confirm this as well. Only the hands get lit, not the world. This affects every type of light, from every block or entity. 2023-09-02_13 15 49

Arae-1 commented 1 year ago

yeah for me it's just the fabric api for versions above 0.85. I hope it gets fixed soon

UnablePath commented 1 year ago

It's been Fixed (see latest commit) he just hasn't pushed a release, I don't know why (probably testing compats idk), you'll either have to build your own .jar or wait till it's ready

madKULOLO commented 1 year ago

It's been Fixed (see latest commit) he just hasn't pushed a release, I don't know why (probably testing compats idk), you'll either have to build your own .jar or wait till it's ready

is it possible to jar for those who are not particularly good at compiling code? :-)

LambdAurora commented 1 year ago

Please do not use MediaFire links, or links to JARs that are not coming from GitHub as I cannot guarantee their safety (even if you do it in good faith).

Please link to the GitHub actions artifacts instead which can be found for this repository and guarantee there is no external actor who's able to interfere with the build process and the JARs.

madKULOLO commented 1 year ago

Please do not use MediaFire links, or links to JARs that are not coming from GitHub as I cannot guarantee their safety (even if you do it in good faith).

Please link to the GitHub actions artifacts instead which can be found for this repository and guarantee there is no external actor who's able to interfere with the build process and the JARs.

oh, how long to wait for the release of the file? (

LambdAurora commented 1 year ago

Here's a Work-in-Progress build: https://github.com/LambdAurora/LambDynamicLights/suites/15654731536/artifacts/893569688

It will give you a .zip file, in which there is the .jar file (and ignore the -sources.jar file)

madKULOLO commented 1 year ago

Here's a Work-in-Progress build: https://github.com/LambdAurora/LambDynamicLights/suites/15654731536/artifacts/893569688

It will give you a .zip file, in which there is the .jar file (and ignore the -sources.jar file)

many thanks to you

Ari-RERA-43 commented 1 year ago

Please do not use MediaFire links, or links to JARs that are not coming from GitHub as I cannot guarantee their safety (even if you do it in good faith).

Please link to the GitHub actions artifacts instead which can be found for this repository and guarantee there is no external actor who's able to interfere with the build process and the JARs.

Apologies. I forgot artifacts existed.

github-actions[bot] commented 1 year ago

This issue is a duplicate!

Please make sure to check for existing issues in this repository before submitting an issue.
If you believe this is a mistake, feel free to reply.