search

LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
392 stars 98 forks source link

1.20.4 support #202

Closed joestr closed 6 months ago

joestr commented 8 months ago

Changes:

Fixes #200 Fixes #204

Note: I'm fairly new to the client modding scene. I only tested the lighting part.

Kichura commented 8 months ago

Despite lighting being about the same as the one in 1.20.2, PR seems to be functioning properly including all GUI pages.

edit: the GUI however seems to be super dark in terms of transparency, unsure if that was intentional.

joestr commented 8 months ago

edit: the GUI however seems to be super dark in terms of transparency, unsure if that was intentional.

I think this is from the SpruceUI library.

TreyRuffy commented 8 months ago

PR seems to work well in 1.20.4!

ajamesmichaels commented 7 months ago

I was also able to build from this branch and run in 1.20.4!

amyipdev commented 7 months ago

Works flawlessly on 1.20.4

DovydasTEDS commented 7 months ago

if possible can a maintainer approve the workflow so that the branch could be merged?

DovydasTEDS commented 7 months ago

@LambdAurora Can you merge this?

KAGUYA-1137 commented 7 months ago

It doesn't seem to work if indium is installed

SA64BD commented 7 months ago

Thanksss!

cptlobster commented 7 months ago

It doesn't seem to work if indium is installed

I didn't have any issues with indium when I tried it. What exactly isn't working? Does the game launch, can you open a world without it crashing, is the dynamic lighting just not working in-game?

KAGUYA-1137 commented 7 months ago

インジウムが取り付けられていると動作しないようです

試してみたところ、インジウムに問題はありませんでした。具体的に何がうまくいっていないのでしょうか?ゲームが起動し、クラッシュせずに世界を開くことができますか、動的ライティングがゲーム内で機能していませんか?

It's not that Indium doesn't work, but that LambDynamicLights almost doesn't work if Indium is installed. The reason I say almost is because non-solid blocks such as tall grass were affected by LambDynamicLights, but solid blocks such as stone and deepslate were not affected by LambDynamicLights.

I'm Japanese so I used Google Translate, sorry for the bad English.