LambdAurora / LambDynamicLights

A dynamic lighting mod for Minecraft on Fabric Loader.
https://lambdaurora.dev/projects/lambdynamiclights/
Other
412 stars 98 forks source link

LambdaControls incompatible with LambDynamicLights version 1.3.3 & above #50

Closed oeramo closed 3 years ago

oeramo commented 3 years ago

Description of the bug I just updated MC to 1.16.5 and subsequently all the mods that I use to the latest versions, and by exclusion it seems like the latest release of LambDynamicLights (1.3.4) breaks the LambdaControls mod. The games launches as expected but, upon opening the controls options page to configure the input mode, a screen appears saying that it is saving the world, even thought I still didn't load one, before the game crashes. If I try to launch the game with the previous version of LambDynamicLights (1.3.2), the controls options page of LambdaControls loads as expected.

To Reproduce Steps to reproduce the behavior:

  1. Launch MC 1.16.5 with lambdynamiclights 1.3.4 & lambdacontrols 1.5.0
  2. Click on Controls > Options
  3. Game claims to be saving a world that still wasn't loaded, then crashes.

Expected behavior Upon clicking on Controls > Options, I should be met with the LambdaControls page that allows to select and configure controllers and other input methods.

Regression After testing it seems that the bug was introduced in LambDynamicLights 1.3.3. As mentioned above, v1.3.2 of the same mod makes LambdaControls work as expected.

Desktop (please complete the following information):

Links to: https://github.com/LambdAurora/LambdaControls/issues/40

LambdAurora commented 3 years ago

I'm gonna to close this issue as the issue should be tracked on LambdAurora/LambdaControls#40.

I need to update LambdaControls, which will take fairly some time as there's a lot of stuff to change for the UI and other stuff

The main reason is just because LambDynamicLights updated with a new version of SpruceUI which is a breaking update because of a lot of internal rework.