LambdAurora / LambDynamicLights

A dynamic lights mod for Minecraft on Fabric Loader.
https://modrinth.com/mod/lambdynamiclights
Other
401 stars 98 forks source link

Update gradle.properties #69

Closed etil2jz closed 3 years ago

etil2jz commented 3 years ago

Fix gradle build

LambdAurora commented 3 years ago

Uh... This doesn't make any sense as the buildscript reformats the version into ${project.minecraft_version}+build.${project.yarn_mappings}. Plus GitHub actions runs the gradle build just fine.

DragonEggBedrockBreaking commented 3 years ago

running gradlew build (or any other task, e.g. remapJar, shadowRemapJar, javaDoc) with the gradle wrapper returns an error:

C:\Users\user\LambDynamicLights>gradlew build

> Configure project :
Fabric Loom: 0.8.20

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\user\LambDynamicLights\build.gradle' line: 178

* What went wrong:
A problem occurred evaluating root project 'lambdynamiclights'.
> No match found

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

C:\Users\user\LambDynamicLights>

running gradle build (or any other task, e.g. remapJar, shadowRemapJar, javaDoc) to use the installed gradle wrapper on my computer (Gradle 7.1) returns a different error:

C:\Users\user\LambDynamicLights>gradle build

> Configure project :
Fabric Loom: 0.8.20

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\user\LambDynamicLights\build.gradle' line: 6

* What went wrong:
An exception occurred applying plugin request [id: 'org.cadixdev.licenser', version: '0.6.0']
> Failed to apply plugin 'org.cadixdev.licenser'.
   > Could not get unknown property 'header' for extension 'base' of type org.gradle.api.plugins.internal.DefaultBasePluginExtension.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

C:\Users\user\LambDynamicLights>

So there seems to be some kind of issue, but it also seems unrelated to what this PR is trying to "fix"

LambdAurora commented 3 years ago

First error is due to a missing CHANGELOG entry somehow, that regex is causing some real trouble.

Second one requires the licenser plugin to be updated.