search

LambdAurora / LambdaControls

A minecraft mod which adds better controls and controller support.
MIT License
67 stars 20 forks source link

MultiMC, settings of key mapping are not saved, OptiFabric conflict. #31

Closed f-c-s closed 3 years ago

f-c-s commented 4 years ago

Hello,

The settings of key mapping are not saved on exit. Each time I open Minecraft I have to set key mapping again.

I didn't test it on single installation of MC.

There is a conflict between your mod and OptiFabric mod.

Regards ML

AMereBagatelle commented 4 years ago

I believe the conflict between this mod and OptiFabric is intentionally specified. (unfixable code conflicts) You can find alternatives for OptiFabric here: https://gist.github.com/LambdAurora/1f6a4a99af374ce500f250c6b42e8754

LambdAurora commented 4 years ago

The settings of key mapping are not saved on exit. Each time I open Minecraft I have to set key mapping again.

This is concerning but despite whatever I do I cannot reproduce this issue, please specify what version of the mod you are using, there is a template for bug reports and it's for a good reason.

OptiFine

I'm not willing to spend time trying to fix an incompatibility caused by the intrusive nature of a mod which is closed source thus making it very difficult to fix the issue legally.

f-c-s commented 3 years ago

Hello,

I use MultiMC and I have a few instances of Minecraft, one for 1.12.2 with forge, and 1.15.2 and 1.16.2 with fabric and your mod for gamepad. The LambdaControl v 1.5.0+1.16.2 is installed for Minecraft 1.16.2, the size of mod is 576027 byes.

Regards ML

Computerlabrat commented 3 years ago

It crashes on Minecraft 1.16.5 with optifabric for me. I can't even launch with it. If it helps, I'm using optifabric-1.9.2 and OptiFine_1.16.5_HD_U_G6.

DragonEggBedrockBreaking commented 3 years ago

It crashes on Minecraft 1.16.5 with optifabric for me. I can't even launch with it. If it helps, I'm using optifabric-1.9.2 and OptiFine_1.16.5_HD_U_G6.

LambdAurora mentions that she will not fix this and optifine is marked as incompatible in fabric.mod.json. Consider Sodium.

Computerlabrat commented 3 years ago

I've thought about it. The main problem is that there are some shaders I use that I don't want to give up as there's no precompiled jar file that works with the shaders I use. I use some realistic texture packs.

supsm commented 3 years ago

Texture packs should work with vanilla, and if you want shaders I recommend checking out canvas. It has some optifine shader features, such as shadows and reflections.

Computerlabrat commented 3 years ago

It doesn't support the same shaders. I'm not sure if it has ports for ones I like or not. The ones I have are Arcane Shaders, Beyond Belief Legacy, BSL, Chocapic, Nostalgia, SEUS Renewed, and Simplicissimus. I do wonder if it supports connected textures, though.

supsm commented 3 years ago

connected block textures is compatible with canvas... also you probably just have to make a trade off with the shaders

Computerlabrat commented 3 years ago

Tried it, Unless there's a site with Canvas Shaders, my other option might be to suggest the Optifine team to implement controller support.

supsm commented 3 years ago

https://github.com/spiralhalo/LumiLights/tree/wip

LambdAurora commented 3 years ago

ButtonBinding not being saved got fixed in e652390.