LambdaLabs / docsy-lambda-docs

3 stars 8 forks source link

Added docker compose command if repo install #115

Closed coreylambda closed 1 year ago

coreylambda commented 1 year ago

There are two ways to install docker compose, both of which are outlined in the official install pages linked to from README.md. If the manual installation is chosen, a binary file named "docker-compose" is created. If installation from the docker repo is chosen, the "docker-compose-plugin" package is installed, which adds compose as a sub-command for docker, so instead of "docker-compose up", you would type "docker compose up". I feel as though both should be referenced, since both installation options are referenced.

cbrownstein-lambda commented 1 year ago

Reviewing this pull request made me think: should we even provide instructions on how to install Docker Compose?

I think it makes sense to provide a specific instruction on how to install Docker Compose in Ubuntu, given that Lambda is largely Ubuntu centric. (Ubuntu is preinstalled on all systems and Cloud instances, for example.) But, otherwise, folks can learn about Docker Compose from outside of our documentation.

I think it's best that the instructions be rewritten as I did in 46673acdeed5b47d0690b1559ee2109f1fbfb408.

@coreylambda: Thoughts?