search

LambdaTest / node-tunnel

LambdaTest Nodejs bindings for Tunnel
https://www.lambdatest.com/
11 stars 16 forks source link

docs: fix logo link #25

Closed vil02 closed 1 year ago

vil02 commented 1 year ago

The LambdaTest logo link was broken in README.md. This PR fixes that (cf. README.md).

Shivanshu-lambdatest commented 1 year ago

@vil02 Thanks for the PR, but in order to publish these changes we need to upgrade the npm version as well in the package.json file. Thanks.

vil02 commented 1 year ago

@Shivanshu-lambdatest I have updated the version.

vil02 commented 1 year ago

@Shivanshu-lambdatest should I also do the same thing in LambdaTest/protractor-selenium-semaphore-sample#5 and LambdaTest/nodejs-cucumber-todo#3 (in both cases update to 0.1.1)? Should I also update the version in pom.xml in LambdaTest/lambdatest-maven-tunnel#16 (to 1.0.14)?

Could you also have a look at:

Shivanshu-lambdatest commented 1 year ago

The logo has been fixed, this is not needed anymore.

vil02 commented 1 year ago

The logo has been fixed, this is not needed anymore.

For sake of clarity I think it is worth to mention the commit bf17f1659afd3b5939f599ec07953b779c34d64d which contains the mentioned fix.