search

LambdaTest / node-tunnel

LambdaTest Nodejs bindings for Tunnel
https://www.lambdatest.com/
11 stars 16 forks source link

Fix Node 18 Unzip Issues #42

Closed DanielHaroldLane closed 1 year ago

DanielHaroldLane commented 1 year ago

This PR is to address the failing unzip package "unzipper" that fails to successfully unzip the LT binary under Node 18. The last package update to "unzipper" was three years ago. Adm-Zip is actively maintained and is functional.

This Addresses #39

DanielHaroldLane commented 1 year ago

I just want to point out that as Node 14 LTS is out of support at the end of this month and Node 16 LTS is out of support at the end of September this PR fixes a critical issue that breaks node-tunnel and prevents it from extracting the LT binary zip on Node 18.

I found this issue because multiple testcafe lambdatest pipelines failed after upgrading to node 18, which I suspect many customers will be doing as we speak. Probably worth merging this as a priority.