Lameguy64 / mkpsxiso

ISO disc image maker written specifically for PlayStation homebrew development
GNU General Public License v2.0
214 stars 33 forks source link

Merging folders with the same name #28

Closed ViToTiV closed 1 year ago

ViToTiV commented 2 years ago

XML structure for example:

<dir name="ANI">
    <dir name="PAL">
        <file name="RMPBASE.PSX" source="ANI/PAL/RMPBASE.PSX" type="data"/>
        <file name="VRMBASE.PSX" source="ANI/PAL/VRMBASE.PSX" type="data"/>
    </dir>
</dir>
<dir name="PAL">
    <file name="BRIEFIN1.PSR" source="PAL/BRIEFIN1.PSR" type="data"/>
    <file name="BRIEFIN2.PSR" source="PAL/BRIEFIN2.PSR" type="data"/>
</dir>

In result image directories "PAL" is merged in "ANI/PAL/" path, and not exist in "PAL/" path

Lameguy64 commented 2 years ago

Well I couldn't recreate this bug myself. What version of mkpsxiso are you using exactly?

ViToTiV commented 2 years ago

On the example of the game "London Racer (Europe)" from redump: Original files structure Structure after rebuild What I did (with last version 2.01):

1. dumpsxiso.exe -s "London Racer (Europe).xml" "London Racer (Europe).bin"
2. mkpsxiso.exe "London Racer (Europe).xml"

All subfolders "U" is merged to first one (DATA\U) And this is not only with this game, but with any game where there are the same folder names in subfolders

CookiePLMonster commented 2 years ago

We have this fixed in a fork, yet to be upstreamed (again): https://github.com/CookiePLMonster/mkpsxiso/commit/9b8445515efba663df798ef037cb31157d85f473

CookiePLMonster commented 1 year ago

This is long fixed.