search

Laminas-Commons / LmcRbacMvc

This repository is being abandoned. Please see LM-Commons/LmcRbacMvc.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Remove dependencies on older version of Zend Framework? #1

Open visto9259 opened 4 years ago

visto9259 commented 4 years ago

The original ZfcRbac allows dependencies on Zf2. Should we remove these dependencies?

daveearley commented 4 years ago

Hi there 👋 ,

We're migrating a small service from 2.X Zend over to Laminas and we're running into an issue due to the old Zend dependencies. Is there a plan to update the 2.X versions to use Laminas dependencies and re-tag? and if there's no immediate plan would you be happy to accept PRs with the changes? Cheers!

visto9259 commented 4 years ago

Can you provide more details on where you are having issues? LmcRbacMvc is the former ZfcRbac v2. We split the former ZfcRbac into two libraries;

daveearley commented 4 years ago

Thanks for getting back. The issue we're having is that when we migrated to Laminas 2.X the service manager is unable to create an instance for Zend\Authentication\AuthenticationService when trying to load RedirectStrategyFactory.

Unfortunately we are unable to jump this legacy service to v3 so we were looking for a way to use the 2.X version but without the Zend dependencies.

visto9259 commented 4 years ago

I must admit that the library versioning is a little confusing. Everything tagged as 2.x is the old ZfcRbac 2.x code. Version 3.x is the version ported to Laminas. We have no plans at the moment to convert older 2.x code to Laminas. "We" in this context is pretty much only me supporting it with limited bandwidth.

Is something in v3 of this library preventing you from using it or is it something else in your app?

daveearley commented 4 years ago

No problem at all, thanks for the response!

Is something in v3 of this library preventing you from using it or is it something else in your app?

Unfortunately we can't use v3 as it would require a jump to v3 Laminas which our legacy service can't support

visto9259 commented 4 years ago

No problem at all, thanks for the response!

Is something in v3 of this library preventing you from using it or is it something else in your app?

Unfortunately we can't use v3 as it would require a jump to v3 Laminas which our legacy service can't support

I have not tested it using a v2 Laminas but there are no significant code changes from ZfcRbac 2.x to LmcRbacMvc 3.x other than changes in the references to Laminas. The composer requirements were bumped to Laminas v3 only but in theory they could include the v2 Laminas dependencies.

I think that what would be needed to support Laminas v2 is to test it on a v2 framework. Did you try to fork this library and update composer to add back the v2 dependencies?

daveearley commented 4 years ago

Not yet but I think that's the route we'll be going down, I'll let you know how I get on. Many thanks for the help!

visto9259 commented 3 years ago

Moved to https://github.com/LM-Commons/LmcRbacMvc/issues/4