search

Lanayx / Oxpecker

ASP.NET Core based F# framework
https://lanayx.github.io/Oxpecker/
MIT License
283 stars 11 forks source link

Use fantomas to check the code #9

Closed 64J0 closed 9 months ago

64J0 commented 9 months ago

Description:

With this PR, I'm adding a new CI workflow to check the code using fantomas.

You can look at how it works on CI here: https://github.com/64J0/Oxpecker/pull/1.

image

Please let me know if you'd like me to change something in this PR so it could be merged.

Lanayx commented 9 months ago

I'm not sure, but tend to think that is shouldn't be a separate action, rather integrated into existing CI workflow, what do you think? Can you please also merge latest changes

64J0 commented 9 months ago

I'm not sure, but tend to think that is shouldn't be a separate action, rather integrated into existing CI workflow, what do you think?

This is a valid option. I'll merge them soon!

Can you please also merge latest changes

Sure.

64J0 commented 9 months ago

Do you prefer to use the same job that is there (build), or to add the fantomas validation as a separate job @Lanayx ?

Lanayx commented 9 months ago

I actually don't have strong opinion on that. Having them in one job is fine, separating dotnet tool in another job also makes sense. So merging it as you made it :)