search

LancePutnam / Gamma

Generic (Sound) Synthesis Library
Other
458 stars 54 forks source link

Multi removed and then returned (see below). ipl::Any renamed to ipl::Switchable. Some changes to the documentation. #15

Closed gitelope closed 12 years ago

gitelope commented 12 years ago

Any-->Switchable Removed Multi and then put it back since Vec inherits from it. @defgroup --> \defgroup. @ingroup --> \ingroup.
Removed @brief's for consistency. Pluck tagged as an Oscillator.
SegExp, Exp, and Gate tagged as Envelopes. Pan tagged as an Effect. @param --> \param Sequence Interpolation and Phase Increment Doxygen groups added.

LancePutnam commented 12 years ago

Would it be possible to create several more orthogonal pull requests instead of one big one? It is somewhat complicated cherry-picking parts of pull requests. In this case, all the changes are acceptable, but that may not always be the case...

LancePutnam commented 12 years ago

Also, before sending a pull request, please run 'make buildtest'. This builds the library, examples, and runs the unit tests. It the best way to check if anything was broken by changes.

I got an error building examples/filter/comb.cpp after merging this pull request.

gitelope commented 12 years ago

Yes, sorry about the long lists of commits.

I've discovered how to create multiple forks of the same repo under the same GitHub user. You can't do this just by clicking on Fork again.

How to Create Multiple Forks of Gamma on GitHub under a single User

clone original repo to local machine from the command line: git clone https://github.com/LancePutnam/Gamma.git forkName cd forkName

new empty repo in GitHub account from GitHub home page: click new Repository name new repo "forkName"

create remote links from the command line: git remote rename origin upstream git remote add origin https://github.com/userName/forkName.git

push from local repo to new remote repo from the command line: git push -u origin master

forkName - name of new fork userName - GitHub user name of individual creating the fork

I created this procedure from the instructions at: http://alt.adrianshort.co.uk/blog/2011/11/08/create-multiple-forks-of-a-github-repo/

gitelope commented 12 years ago

Also, thanks for the tip on using 'make buildtest'. I'd been using just 'make tests/unitTests.cpp' so I didn't catch the outdated usage in comb.cpp.

LancePutnam commented 12 years ago

Are you saying you aren't allowed to do a pull request on only certain commits in your branch? I would have assumed that by default every commit equates to a pull request...

gitelope commented 12 years ago

GitHub doesn't allow for you to choose what goes along with your pull request as far as I can tell.

There may be ways to do this without creating multiple branches or forks, but I'm not sure if they are worth the trouble: http://stackoverflow.com/questions/8450036/how-to-open-multiple-pull-requests-on-github