search

LancePutnam / Gamma

Generic (Sound) Synthesis Library
Other
458 stars 54 forks source link

pstdint.h and Windows #24

Closed LancePutnam closed 10 years ago

LancePutnam commented 10 years ago

Gamma/pstdint.h conflicts with stdint.h which is now included with VS10+. Either pstdint.h should be updated or other environments (namely MinGW) should be tested against a standard #include <stdint.h> hence removing the need for pstdint.h.

olilarkin commented 10 years ago

also pstdint.h is #included in 4 different places i think. Shouldn't it just be the once in Types.h?

LancePutnam commented 10 years ago

I'm not sure it would make sense to include Types.h in the other files since they only depend on uint32_t, etc.

olilarkin commented 10 years ago

pstdint.h is still included in Constants.h

On 10 Jun 2014, at 14:40, Lance Putnam wrote:

Closed #24.

— Reply to this email directly or view it on GitHub.

LancePutnam commented 10 years ago

It's still needed for older versions of VS. It should simply include stdint.h for the newer versions of VS that have it.

olilarkin commented 10 years ago

It's not working for me in VS2010. I get a lot of "error C2371: 'uint32_t' : redefinition; different basic types", stemming from conversion.h including constants.h

if i comment out pstdint.h and include stdint.h instead the errors go