LFO Line2 Mod Errors - Githubissues

LancePutnam / Gamma

Generic (Sound) Synthesis Library

Other

458 stars 54 forks source link

LFO Line2 Mod Errors #31

Closed mhetrick closed 8 years ago

mhetrick commented 8 years ago

The Line2() output for the LFO class behaves incorrectly with mod values >.98 and <.02. Behavior should be predictable for all values -1 to +1.

LancePutnam commented 8 years ago

Looks okay to me for all values except possibly mod=1 where the ramp flips from up to down. Is this what you are observing?

mhetrick commented 8 years ago

After further testing, yes, that's the issue that we were observing. The other values were issues with our visualizer code.

LancePutnam commented 8 years ago

I'll close this issue then. I also think mod values should be "periodic" so that 0 and 1 produce the same waveform (but that would be better opened as another issue).