search

LancePutnam / Gamma

Generic (Sound) Synthesis Library
Other
462 stars 55 forks source link

Fixes for LLVM GCC #4

Closed Amusesmile closed 12 years ago

Amusesmile commented 12 years ago

Hey Lance, So I upgraded to mountain lion which means that I have to use LLVM GCC which ended up breaking Gamma.

In order to get it working again, I made changes to arr.h, Envelope.h, and Filter.h. The main fix was to add "this->" in some of the class declarations. I'm sure there're more that need to be changed but all of the examples work and that's all I was able to test. Anyway if you're interested in pulling these changed I'd be honored and I won't be offended if you decide against it. Karl tested them as well.

best,

LancePutnam commented 12 years ago

I tried merging your changes with the master, but ran into serious problems. Thus, I did some things manually: add 'this->' to nondependent names, create sumSquares prototype (hopefully this still works for you), and add examples/synths/. Is there a reason why we need to append _tutorial to the tutorial files? It seems redundant to me since they are already in a directory called 'tutorial'.

In the future, can you please try to break up your pull requests into smaller orthogonal pieces? That way I can more easily close off individual issues. Thanks!

Amusesmile commented 12 years ago

Wow thanks so much Lance. These changes all work great and you even got rid of some of the random pesky warnings. There's one last change in arr.h that I had to make before it would compile. I'll close this pull request then grab your changes then make that fix and do another pull request.