LancePutnam / Gamma

Generic (Sound) Synthesis Library
Other
458 stars 54 forks source link

Fixes for warnings, bad defaults, and template errors. #50

Closed mhetrick closed 6 years ago

mhetrick commented 6 years ago

In a typical Windows plugin project, Gamma generates a couple thousand warnings for various reasons. Most of these are because of unreferenced formal parameters, but there are a handful of casting performance warnings as well.

In addition, there are bad default arguments for Echo<>. It defaults to a LoopFilter that doesn't have a damping() function, so creating one without arguments throws out some inscrutable template errors.

Finally, in the Biquad code there were two instances of explicit float usage instead of templated variables. This worked fine when using the default gam::real type, but compilation would fail when trying to use Biquad.

There are still a handful of unused function warnings remaining on Mac and Windows with typicaly build settings, but this pull request greatly reduces the number.