Closed Danielxs01 closed 1 year ago
Tested the following changes:
ContentPackHandler.java Was before:
try (ZipFile zip = new ZipFile(asset)) {
Tested unsuccessfully:
try (ZipFile zip = new ZipFile(asset, StandardCharset.UTF_8)) {
try (ZipFile zip = new ZipFile(asset, StandardCharset.UTF_16)) {
Tested successfully:
try (ZipFile zip = new ZipFile(asset, StandardCharset.ISO_8859_1)) {
_The ContentPackHandler tries opening the ContentPack with UTF-8. If that fails it will retry with ISO_88591 with the following messages:
Console:
[19:45:25] [main/INFO]: [cam72cam.mod.ModCore:info:242]: INFO: Loading Asset: D:\IMPORTANT_repositories\LandOfSignals\run\.\config\landofsignals\dk_layout.zip
[19:45:25] [main/INFO]: [cam72cam.mod.ModCore:info:242]: INFO: Encoding: UTF-8
[19:45:25] [main/INFO]: [cam72cam.mod.ModCore:warn:251]: WARN: Failed loading content with UTF-8. Trying ISO_8859_1 next. Try fixing this if possible. See wiki.
[19:45:25] [main/INFO]: [cam72cam.mod.ModCore:info:242]: INFO: Loading Asset: D:\IMPORTANT_repositories\LandOfSignals\run\.\config\landofsignals\dk_layout.zip
[19:45:25] [main/INFO]: [cam72cam.mod.ModCore:info:242]: INFO: Encoding: ISO-8859-1
Item tooltip:
WARNING: This Item/Block was loaded with ISO_8859_1 encoding instead of UTF-8 due to illegal characters. This item/block may not work as intended.
Done
Improved errorhandling with special characters in contentpacks
As mentioned under help on our discord. Special characters produce the following stacktrace:
This should either be fixed or handled properly.