LandRegistry / govuk-frontend-jinja

GOV.UK Frontend Jinja Macros
https://pypi.org/project/govuk-frontend-jinja/
MIT License
34 stars 13 forks source link

Refactor/accessibility improvements #69

Closed GeorgeGoodall closed 1 year ago

GeorgeGoodall commented 1 year ago

What's New

Why were these changes to make

matthew-shaw commented 1 year ago

Hi @GeorgeGoodall thanks very much for the PR. However, I don't think this is something that should be done at this level. If there are accessibility issues with the generated HTML output from the Jinja templates, then they also exist with the original Nunjucks templates that these were ported from. GOV.UK Frontend Jinja is a like-for-like port of the original GOV.UK Frontend, and tested against it to ensure the markup is 100% identical, any changes made here would break that parity. So this needs to be done at source, which will end up in this package as well after release.

I would check the issues against GOV.UK Frontend and see if the problem has already been raised: https://github.com/alphagov/govuk-frontend/issues Or ask the team on the X-Gov Slack channel govuk-design-system for advice.

Thanks again