Latent Effects don't load when equipped and zoning

LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI

https://landsandboat.github.io/server/

GNU General Public License v3.0

296 stars 595 forks source link

Latent Effects don't load when equipped and zoning #1081

Open Skerxan opened 2 years ago

Skerxan commented 2 years ago

[x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
[x] I have searched existing issues to see if the issue has already been opened
[x] I have checked the commit log to see if the issue has been resolved since my server was last updated
[x] I have read the Contributing Guide
[x] I have specified what branch this happens on branch: EDITME

Additional Information (Steps to reproduce/Expected behavior) :

We had several reports of items like CoP rings, Destrier Beret and Shadow Mantle without active latent effects even when they should be active. It happens when you zone somewhere or log-in. This gets usually fixed by re-equipping the gear.

TeoTwawki commented 2 years ago

I haven't seen this yet, but it may be that the specific latents used on your server aren't in use don mine..except CoP rings. My CoP rings are def workin on zone !

Skerxan commented 2 years ago

I also had this tested and reported on another server ages ago which closed down.

Try having any stats-increasing latents equipped and relog. See if they are active when you log-in. Then re-equip them. See the changes.

personaone commented 2 years ago

yup actually can confirm with ninja boots during nighttime, zoning with them on actually doesn't kick in the latent until you re-equip the item, it's at night of course.

TeoTwawki commented 2 years ago

I am wondering if we flubbing the packets at zonetime so the client isn't being informed, or if server side the latent code is truly not being called when the entity is rebuilt on the other side..

These -were- working not all that long ago from my perspective. Not sure whats changed.

Skerxan commented 2 years ago

There seems to be another bug that may relate to this one. It seems that latents stay active even if their triggering condition is gone again. Until you zone atleast. This has been the case with Destrier Berets lvl 30 condition. It would still give the player the stats above lvl 30. Or i am entirely wrong and its just a problem with their mods or something else. Didn't dig deeper into it yet.