Guild shop AUDIT and rework needed

TeoTwawki commented 2 years ago

We've had longstanding issues with guild shops. This has been exacerbated by the many changes retail has made to them that we never caught up on.

Retail now has 2 types of guild shop:

TypeA: fluctuating prices, when stock is low guild pays more for the item and charges more. As stock rises the price goes low and the guild doesn't pay as much. When maxed price bottoms out but guild refuses to buy. This allowed for what server operations often consider exploitation even on retail... But now modern pricing is quit different from when these were recorded into SQL.
TypeB: these have a static price and unlimited stock gated behind craft ranks. This has a completely different system in our codebase than TypeA and is done in Lua script instead of SQL.

To ~~silence~~ fix this once and for all, I propose a full re-audit of all shop NPCs ending with us setting both types of shop at least relative to retails TypeB shop values and a move from sql to Lua script.

Note that in the current system, the sql colums for min and max may not grant results a layperson might expect in game. When the shop is buying from the player, the maximum price is generally sql max divided by 3.

Contributors and reporters, please make this your one-stop for all things guild pricing related.

DO NOT TRUST THE WIKI'S - VERIFY IN GAME

[ ] Woodworking: Chaupire, Northern San d'Oria (E-3)
[ ] Woodworking: Cauzeriste, Northern San d'Oria (E-3)
[ ] Woodworking: Beugungel, Carpenters' Landing (H-8)
[ ] Woodworking: Dehbi Moshal, Al Zahbi (G-10)
[ ] Smithing: Doggomehr, Northern San d'Oria (E-5)
[ ] Smithing: Lucretia, Northern San d'Oria (E-6)
[ ] Smithing: Mololo, Mhaura (G-9)
[ ] Smithing: Kamilah, Mhaura (G-9)
[ ] Smithing: Amulya, Metalworks (E-9)
[ ] Smithing: Vicious Eye, Metalworks (E-9)
[ ] Smithing: Ndego, Al Zahbi (H-9)
[ ] Goldsmithing: Celestina, Mhaura (G-8)
[ ] Goldsmithing: Yabby Tanmikey, Mhaura (G-8)
[ ] Goldsmithing: Visala, Bastok Markets (H-8)
[ ] Goldsmithing: Teerth, Bastok Markets (H-8)
[ ] Goldsmithing: Bornahn, Al Zahbi (J-10)
[ ] Clothcraft: Meriri, Windurst Woods (F-12)
[ ] Clothcraft: Kuzah Hpirohpon, Windurst Woods (F-12)
[ ] Clothcraft: Tilala, Selbina (H-9)
[ ] Clothcraft: Gibol, Selbina (H-9)
[ ] Clothcraft: Tatan-Bilten, Al Zahbi (J-10)
[ ] Leathercraft: Cletae, Southern San d'Oria (D-8)
[ ] Leathercraft: Kueh Igunahmori, Southern San d'Oria (D-8)
[ ] Bonecraft: Shih Tayuun, Windurst Woods (H-12) 8-23
[ ] Bonecraft: Retto-Marutto, Windurst Woods (H-12) 8-23
[ ] Alchemy: Odoba, Bastok Mines (K-6)
[ ] Alchemy: Maymunah, Bastok Mines (K-7)
[ ] Alchemy: Wahraga, Aht Urhgan Whitegate (G-5)
[ ] Alchemy: Gathweeda, Aht Urhgan Whitegate (G-5)
[ ] Cooking: Chomo Jinjahl, Windurst Waters (E-8)
[ ] Cooking: Kopopo, Windurst Waters (E-8)
[ ] Fishing: Babubu, Port Windurst (C-8)
[ ] Fishing: Mendoline, Selbina (H-9)
[ ] Fishing: Graegham, Selbina (H-9)
[ ] Fishing: Mep Nhapopoluko, Bibiki Bay (H-7)
[ ] Fishing: Rajmonda, Ship bound for Selbina
[ ] Fishing: Lokhong, Ship bound for Mhaura
[ ] Fishing: Pashi Maccaleh, Open sea route to Al Zahbi
[ ] Fishing: Cehn Teyohngo, Open sea route to Mhaura
[ ] Fishing: Yahliq, Silver Sea route to Al Zahbi
[ ] Fishing: Jidwahn, Silver Sea route to Nashmau
[ ] Fishing: Wahnid, Aht Urhgan Whitegate (H-11)

kaincenteno commented 2 years ago

i could have sworn doing an audit on the ones that don't fluctuate their prices when the extra packet that allows the purchase of the items depending on the craft level was introduced, did they made more changes afterwards? if not only the npc with the changing prices need an audit

TeoTwawki commented 2 years ago

@kaincenteno just gonna double check ALL of them at this point. Found prices wrong on both kinds.

detetivepro15 commented 2 years ago

Tivemos problemas de longa data com as lojas da guilda. Isso foi exacerbado pelas muitas mudanças que o varejo fez neles que nunca alcançamos.

O varejo agora tem 2 tipos de loja de guilda:

Tipo A: preços flutuantes, quando o estoque está baixo a guilda paga mais pelo item e cobra mais. À medida que o estoque sobe, o preço cai e a guilda não paga tanto. Quando o preço máximo cai, mas a guilda se recusa a comprar. Isso permitiu o que as operações de servidor geralmente consideram exploração mesmo no varejo... Mas agora os preços modernos são diferentes de quando estes foram registrados no SQL.

Tipo B: estes têm um preço estático e estoque ilimitado fechado atrás das fileiras de artesanato. Isso tem um sistema completamente diferente em nossa base de código do que o TypeA e é feito em script Lua em vez de SQL.

Para~silêncio~ conserte isso de uma vez por todas, proponho uma re-auditoria completa de todos os NPCs da loja terminando com a configuração de ambos os tipos de loja pelo menos em relação aos valores da loja de varejo TypeB e uma mudança do script sql para Lua.

Observe que no sistema atual, as colunas sql para min e max podem não conceder resultados que um leigo possa esperar no jogo. Quando a loja está comprando do jogador, o preço máximo geralmente é sql max dividido por 3.

Contribuidores e repórteres, por favor, façam deste seu ponto de parada para todas as coisas relacionadas a preços de guildas.

NÃO CONFIE NO WIKI'S - VERIFICAR NO JOGO

[x] Marcenaria: Chaupire, norte de San d'Oria (E-3)

[x] Marcenaria: Cauzeriste, Norte de San d'Oria (E-3)

[x] Carpintaria: Beugungel, Carpenters' Landing (H-8)

[x] Marcenaria: Dehbi Moshal, Al Zahbi (G-10)

[x] Metalurgia: Doggomehr, norte de San d'Oria (E-5)

[x] Metalurgia: Lucretia, norte de San d'Oria (E-6)

[x] Metalurgia: Mololo, Mhaura (G-9)

[x] Metalurgia: Kamilah, Mhaura (G-9)

[x] Metalurgia: Amulya, Metalúrgica (E-9)

[x] Metalurgia: Vicious Eye, Metalworks (E-9)

[x] Metalurgia: Ndego, Al Zahbi (H-9)

[x] Ourivesaria: Celestina, Mhaura (G-8)

[x] Ourivesaria: Yabby Tanmikey, Mhaura (G-8)

[x] Ourivesaria: Visala, Bastok Markets (H-8)

[x] Ourivesaria: Teerth, Bastok Markets (H-8)

[x] Ourivesaria: Bornahn, Al Zahbi (J-10)

[x] Artesanato: Meriri, Windurst Woods (F-12)

[x] Clothcraft: Kuzah Hpirohpon, Windurst Woods (F-12)

[ ] Artesanato: Tilala, Selbina (H-9)

[x] Artesanato: Gibol, Selbina (H-9)

[x] Artesanato: Tatan-Bilten, Al Zahbi (J-10)

[x] Couraria: Cletae, Sul de San d'Oria (D-8)

[x] Couraria: Kueh Igunahmori, sul de San d'Oria (D-8)

[x] Bonecraft: Shih Tayuun, Windurst Woods (H-12) 8-23

[x] Bonecraft: Retto-Marutto, Windurst Woods (H-12) 8-23

[x] Alquimia: Odoba, Minas Bastok (K-6)

[x] Alquimia: Maymunah, Minas Bastok (K-7)

[x] Alquimia: Wahraga, Aht Urhgan Whitegate (G-5)

[x] Alquimia: Gathweeda, Aht Urhgan Whitegate (G-5)

[x] Culinária: Chomo Jinjahl, Windurst Waters (E-8)

[ ] Culinária: Kopopo, Windurst Waters (E-8)

[x] Pesca: Babubu, Porto Windurst (C-8)

[x] Pesca: Mendoline, Selbina (H-9)

[x] Pesca: Graegham, Selbina (H-9)

[x] Pesca: Mep Nhapopoluko, Baía de Bibiki (H-7)

[x] Pesca: Rajmonda, Navio com destino a Selbina

[x] Pesca: Lokhong, Navio com destino a Mhaura

[x] Pesca: Pashi Maccaleh, rota de mar aberto para Al Zahbi

[x] Pesca: Cehn Teyohngo, rota de mar aberto para Mhaura

[x] Pesca: Yahliq, rota do Mar de Prata para Al Zahbi

[x] Pesca: Jidwahn, rota do Mar de Prata para Nashmau

[x] Pesca: Wahnid, Aht Urhgan Whitegate (H-11)

yes

detetivepro15 commented 2 years ago

yes

TeoTwawki commented 2 years ago

I had hoped this issue being stickied to the top of the tracker would garner some interest form people with retail accounts, since it's easy to perform the needed checking. But so far all I got was a quoted + translated my checklist and checked many boxes without saying what was supposedly confirmed for them. I haven't seen PR's referencing this issue number either, and I know some items have off pricing or stock or both so I guess I'm going to wind up checking them all myself.

TeoTwawki commented 10 months ago

this is just an unfathomable mess, and I think the guild contents should be thrown the F out and redone. i just checked 2 guild shops than they have like 50 items listed that retail's shop will neither buy nor sell. So thats not even pricing - the items just shouldn't be in there at all!

LandSandBoat / server

Guild shop AUDIT and rework needed #1191

DO NOT TRUST THE WIKI'S - VERIFY IN GAME

NÃO CONFIE NO WIKI'S - VERIFICAR NO JOGO