LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
298 stars 599 forks source link

npcUtil Trade functions do not account for future space available #142

Closed claywar closed 2 years ago

claywar commented 3 years ago

Additional Information (Steps to reproduce/Expected behavior) :

If player inventory is full on trade, a failure will occur if an item is awarded on trade complete.

Example: Inventory Full, required trade is 5 items, onTrade complete awards one item.

Trade 5, and after trade there should be sufficient space to receive one, but failure is still returned.

zach2good commented 3 years ago

That's correct no? I can't trade my ambu currency/items when I have a full inventory, even if the end result should be one less space than I started with. (I think)

claywar commented 3 years ago

I don't recall it happening in retail, but definitely a good thing to confirm.

TeoTwawki commented 3 years ago

Retail exhibits the same behavior in all cases I have ever encountered - requiring space to exit prior to trade initiation disregarding space freed by the trade