LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
301 stars 612 forks source link

Mission Windurst 5-1 Final Seal - New Fei'Yin Seal not Rewarded upon CS completion #1527

Open Kalifriki opened 2 years ago

Kalifriki commented 2 years ago

Additional Information (Steps to reproduce/Expected behavior) : https://ffxiclopedia.fandom.com/wiki/The_Final_Seal

After completing the cutscene with Star Sibyl player is not given the KI New Fei'Yin Seal to be used to trigger the bcnm fight. If KI is generated; Mission will complete as normal and reward Burnt Seal after completing fight. Same issue has been replicated on both the Dawnbreak and Rebirth LSB based servers.

claywar commented 2 years ago

This KI is given on accepting either of the cutscenes from that door in Heaven's Tower. If for some reason on those servers the KI was not deleted, the function will not display receiving the Key Item.

local handleAcceptMission = function(player, csid, option, npc)
    if option == 0 then
        mission:begin(player)
        player:setMissionStatus(mission.areaId, 10)
        player:messageSpecial(zones[player:getZoneID()].text.YOU_ACCEPT_THE_MISSION)
        npcUtil.giveKeyItem(player, xi.ki.NEW_FEIYIN_SEAL)
    end

    player:delKeyItem(xi.ki.MESSAGE_TO_JEUNO_WINDURST)
end
Kalifriki commented 2 years ago

The characters still have KI Message to Jeuno from--the old quest system and the interaction system may be causing an issue. Regardless of lacking in-game message, KI New Fei'Yin seal does not naturally populate.

Neither server has modified the missions and are using LSB base for the mission framework.

claywar commented 2 years ago

That's because we don't force the message. npcUtil.giveKeyItem only displays giving a KI if it succeeds (aka, the player does not have one)

Kalifriki commented 2 years ago

We are having a communication disconnect. I am confirming that the previous mission KI Message to Jeuno is not being consumed and no KI New FeiYin is being rewarded to the player upon resolution of cutscene with Star Sibyl.

Bug_TempKI_NotConsumed

Truth be told...there's numerous Temporary Key Items that are never consumed while working on content [character is Rank 10 Windurst]. Much of the time requires GM/admin intervention to create the proper mission status...as did this character, twice for 5-1 and 8-2.